From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option Date: Wed, 7 Sep 2011 11:22:48 -0700 Message-ID: <20110907182248.GA2874@core.coreip.homeip.net> References: <1315317317-21873-1-git-send-email-thomas.abraham@linaro.org> <1315317317-21873-2-git-send-email-thomas.abraham@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1315317317-21873-2-git-send-email-thomas.abraham@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org To: Thomas Abraham Cc: devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, linux-input@vger.kernel.org, kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jy0922.shim@samsung.com, dh09.lee@samsung.com List-Id: devicetree@vger.kernel.org Hi Thomas, On Tue, Sep 06, 2011 at 07:25:16PM +0530, Thomas Abraham wrote: > Samsung keyboard driver could be used with platforms using device tree. > So the inclusion of samsung keyboard driver cannot be based on > SAMSUNG_DEV_KEYPAD. A new config option HAVE_SAMSUNG_KEYPAD is added > which device tree based platforms should use to include samsung keyboard > driver. I am sorry, I do not follow... What is the difference between SAMSUNG_DEV_KEYPAD and HAVE_SAMSUNG_KEYPAD? They look exactly the same. Thanks, > > Signed-off-by: Thomas Abraham > --- > drivers/input/keyboard/Kconfig | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig > index b4dee9d..370fb18 100644 > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > @@ -423,9 +423,16 @@ config KEYBOARD_PMIC8XXX > To compile this driver as a module, choose M here: the module will > be called pmic8xxx-keypad. > > +config HAVE_SAMSUNG_KEYPAD > + bool > + help > + This will include Samsung Keypad controller driver support. If you > + want to include Samsung Keypad support for any machine, kindly > + select this in the respective mach-xxxx/Kconfig file. > + > config KEYBOARD_SAMSUNG > tristate "Samsung keypad support" > - depends on SAMSUNG_DEV_KEYPAD > + depends on SAMSUNG_DEV_KEYPAD || HAVE_SAMSUNG_KEYPAD > help > Say Y here if you want to use the Samsung keypad. > > -- > 1.6.6.rc2 > -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Wed, 7 Sep 2011 11:22:48 -0700 Subject: [PATCH 1/2] input: samsung-keypad: Add HAVE_SAMSUNG_KEYPAD config option In-Reply-To: <1315317317-21873-2-git-send-email-thomas.abraham@linaro.org> References: <1315317317-21873-1-git-send-email-thomas.abraham@linaro.org> <1315317317-21873-2-git-send-email-thomas.abraham@linaro.org> Message-ID: <20110907182248.GA2874@core.coreip.homeip.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thomas, On Tue, Sep 06, 2011 at 07:25:16PM +0530, Thomas Abraham wrote: > Samsung keyboard driver could be used with platforms using device tree. > So the inclusion of samsung keyboard driver cannot be based on > SAMSUNG_DEV_KEYPAD. A new config option HAVE_SAMSUNG_KEYPAD is added > which device tree based platforms should use to include samsung keyboard > driver. I am sorry, I do not follow... What is the difference between SAMSUNG_DEV_KEYPAD and HAVE_SAMSUNG_KEYPAD? They look exactly the same. Thanks, > > Signed-off-by: Thomas Abraham > --- > drivers/input/keyboard/Kconfig | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig > index b4dee9d..370fb18 100644 > --- a/drivers/input/keyboard/Kconfig > +++ b/drivers/input/keyboard/Kconfig > @@ -423,9 +423,16 @@ config KEYBOARD_PMIC8XXX > To compile this driver as a module, choose M here: the module will > be called pmic8xxx-keypad. > > +config HAVE_SAMSUNG_KEYPAD > + bool > + help > + This will include Samsung Keypad controller driver support. If you > + want to include Samsung Keypad support for any machine, kindly > + select this in the respective mach-xxxx/Kconfig file. > + > config KEYBOARD_SAMSUNG > tristate "Samsung keypad support" > - depends on SAMSUNG_DEV_KEYPAD > + depends on SAMSUNG_DEV_KEYPAD || HAVE_SAMSUNG_KEYPAD > help > Say Y here if you want to use the Samsung keypad. > > -- > 1.6.6.rc2 > -- Dmitry