All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/10] microblaze: Fix in/out_be8/16/32 functions
Date: Wed, 07 Sep 2011 22:59:38 +0200	[thread overview]
Message-ID: <20110907205938.B7424140875B@gemini.denx.de> (raw)
In-Reply-To: <1314779721-1113-2-git-send-email-monstr@monstr.eu>

Dear Michal Simek,

In message <1314779721-1113-2-git-send-email-monstr@monstr.eu> you wrote:
> Use inline functions instead of macros because
> of typechecking.

I don't understand the rationale of this change.

> -#define in_8(addr)	readb (addr)
> -#define in_be16(addr)	readw (addr)
> -#define in_be32(addr)	readl (addr)
> +extern inline int in_8(volatile unsigned char *addr)
> +{
> +	return readb(addr);
> +}

What;s the difference wether the type checking occurs for the in_8()
call or for the readb() call?

> +extern inline int in_be16(volatile unsigned short *addr)

Also, checkpatch says:

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#106: FILE: arch/microblaze/include/asm/io.h:49:
+extern inline int in_8(volatile unsigned char *addr)

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#111: FILE: arch/microblaze/include/asm/io.h:54:
+extern inline int in_be16(volatile unsigned short *addr)

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#119: FILE: arch/microblaze/include/asm/io.h:59:
+extern inline int in_be32(volatile unsigned int *addr)

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#124: FILE: arch/microblaze/include/asm/io.h:64:
+extern inline void out_8(volatile unsigned char *addr, char val)

WARNING: space prohibited between function name and open parenthesis '('
#126: FILE: arch/microblaze/include/asm/io.h:66:
+	outb (val, addr);

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#129: FILE: arch/microblaze/include/asm/io.h:69:
+extern inline void out_be16(volatile unsigned short *addr, short val)

WARNING: space prohibited between function name and open parenthesis '('
#131: FILE: arch/microblaze/include/asm/io.h:71:
+	outw (val, addr);

WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#134: FILE: arch/microblaze/include/asm/io.h:74:
+extern inline void out_be32(volatile unsigned int *addr, int val)

WARNING: space prohibited between function name and open parenthesis '('
#136: FILE: arch/microblaze/include/asm/io.h:76:
+	outl (val, addr);

total: 0 errors, 9 warnings, 41 lines checked

Please fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I believe you find life such a problem because you  think  there  are
the  good  people  and the bad people. You're wrong, of course. There
are, always and only, the bad people, but some of them are  on  oppo-
site sides.                      - Terry Pratchett, _Guards! Guards!_

      parent reply	other threads:[~2011-09-07 20:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31  8:35 [U-Boot] Microblaze changes Michal Simek
2011-08-31  8:35 ` [U-Boot] [PATCH 01/10] microblaze: Fix in/out_be8/16/32 functions Michal Simek
2011-08-31  8:35   ` [U-Boot] [PATCH 02/10] microblaze: Support CTRL+C when tftp is running Michal Simek
2011-08-31  8:35     ` [U-Boot] [PATCH 03/10] microblaze: Support flashes on lower addresses Michal Simek
2011-08-31  8:35       ` [U-Boot] [PATCH 04/10] microblaze: Add netconsole support Michal Simek
2011-08-31  8:35         ` [U-Boot] [PATCH 05/10] microblaze: Fix unaligned.h for endians Michal Simek
2011-08-31  8:35           ` [U-Boot] [PATCH 06/10] microblaze: Copy bootfile from variables Michal Simek
2011-08-31  8:35             ` [U-Boot] [PATCH 07/10] microblaze: Remove debug saving value Michal Simek
2011-08-31  8:35               ` [U-Boot] [PATCH 08/10] microblaze: Setup MB vectors if feature is enable for u-boot Michal Simek
2011-08-31  8:35                 ` [U-Boot] [PATCH 09/10] microblaze: Save and restore first unused vector Michal Simek
2011-08-31  8:35                   ` [U-Boot] [PATCH 10/10] microblaze: Clean up reset asm code Michal Simek
2011-08-31 19:20           ` [U-Boot] [PATCH 05/10] microblaze: Fix unaligned.h for endians Mike Frysinger
2011-09-01 12:51             ` Michal Simek
2011-08-31 19:19         ` [U-Boot] [PATCH 04/10] microblaze: Add netconsole support Mike Frysinger
2011-09-01 13:04           ` Michal Simek
2011-09-07 21:02         ` Wolfgang Denk
2011-08-31 19:18       ` [U-Boot] [PATCH 03/10] microblaze: Support flashes on lower addresses Mike Frysinger
2011-09-01 12:55         ` Michal Simek
2011-09-07 21:01       ` Wolfgang Denk
2011-09-07 20:59   ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110907205938.B7424140875B@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.