From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH v2 0/3] Support character literals Date: Thu, 8 Sep 2011 15:03:54 +1000 Message-ID: <20110908050354.GP30278@yookeroo.fritz.box> References: <1315437340-1661-1-git-send-email-robotboy@chromium.org> <20110908031842.GL30278@yookeroo.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20110908031842.GL30278-787xzQ0H9iQXU02nzanrWNbf9cGiqdzd@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Anton Staaf Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Sep 08, 2011 at 01:18:42PM +1000, David Gibson wrote: > On Wed, Sep 07, 2011 at 04:15:37PM -0700, Anton Staaf wrote: > > These patches add simple and escaped character literal parsing support > > to the dtc for cell lists and bytestrings. The first patch refactors the > > string parsing code in data.c to expose the more primitive character parsing > > code for use in the later patches. I have left the bytestring support in > > place but my hope is that it is now separate enough to be discussed > > independantly of the refactor and cell list changes. > > > > Thanks, > > Anton > > > > Changes in v2: > > - Move the refactor of data.c to a separate patch > > - Add support for character literals in cell lists > > - Merge normal and escaped literal support for bytestrings into > > - single patch > > Getting very close with version, although there are still some minor > warts I'd like you to address. Oh, and one other thing, I forgot to say yet: you need some testcases for the new functionality. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson