From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Zhang Subject: Re: [PATCH 45/62] net: irq: Remove IRQF_DISABLED Date: Thu, 8 Sep 2011 21:41:09 +0800 Message-ID: <20110908134108.GC2310@zhy> References: <1315383059-3673-46-git-send-email-yong.zhang0@gmail.com> <20110907.131325.897937687962213943.davem@davemloft.net> <20110907.135234.17759197083710999.davem@davemloft.net> Reply-To: Yong Zhang Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: perex@perex.cz, dhowells@redhat.com, prakity@marvell.com, netdev@vger.kernel.org, chunkeey@googlemail.com, sonic.zhang@analog.com, klaus.kudielka@ieee.org, t.sailer@alumni.ethz.ch, khilman@ti.com, eric.dumazet@gmail.com, jhovold@gmail.com, cyril@ti.com, rmk+kernel@arm.linux.org.uk, mingo@elte.hu, jpr@f6fbb.org, adobriyan@gmail.com, jreuter@yaina.de, cbe-oss-dev@lists.ozlabs.org, martinez.javier@gmail.com, samuel@sortiz.org, vapier@gentoo.org, grundler@parisc-linux.org, tklauser@distanz.ch, lucas.demarchi@profusion.mobi, u.kleine-koenig@pengutronix.de, olof@lixom.net, uclinux-dist-devel@blackfin.uclinux.org, linux-hams@vger.kernel.org, leitao@linux.vnet.ibm.com, blogic@openwrt.org, shawn.guo@linaro.org, nico@fluxnic.net, geoff@infradead.org, jkosina@suse.cz, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, ralph.hempel@lantiq.com, jdmas To: Thomas Gleixner Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org List-Id: netdev.vger.kernel.org On Wed, Sep 07, 2011 at 08:03:14PM +0200, Thomas Gleixner wrote: > On Wed, 7 Sep 2011, David Miller wrote: > > > From: Thomas Gleixner > > Date: Wed, 7 Sep 2011 19:32:39 +0200 (CEST) > > > > > On Wed, 7 Sep 2011, David Miller wrote: > > > > > >> From: Yong Zhang > > >> Date: Wed, 7 Sep 2011 16:10:42 +0800 > > >> > > >> > This flag is a NOOP and can be removed now. > > >> > > > >> > Signed-off-by: Yong Zhang > > >> > > >> I have the same concerns here as I had for the sparc case. > > >> > > >> Some of these drivers might be using IRQF_DISABLED to make sure the > > >> IRQ cannot be delivered until it is explicitly enabled via an > > >> enable_irq() call. > > >> > > >> How is that being accomodated now? > > > > > > Again IRQF_DISABLED never ever had that functionality. > > > > My bad. > > > > But what if these interrupts want interrupts disabled during their > > interrupt handler, for other reasons? > > We run ALL interrupt handlers with irqs disabled always. > > > This has the potential to break tons of stuff, especially on the > > really old chips which almost no developers have any more but some > > user might try to use. > > It won't. We removed IRQF_DISABLED from kernel/irq/* long ago Yeah, and this is why we say it's a NOOP now :) Thanks, Yong From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 8 Sep 2011 21:41:09 +0800 From: Yong Zhang To: Thomas Gleixner Subject: Re: [PATCH 45/62] net: irq: Remove IRQF_DISABLED Message-ID: <20110908134108.GC2310@zhy> References: <1315383059-3673-46-git-send-email-yong.zhang0@gmail.com> <20110907.131325.897937687962213943.davem@davemloft.net> <20110907.135234.17759197083710999.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: Cc: perex@perex.cz, dhowells@redhat.com, prakity@marvell.com, netdev@vger.kernel.org, chunkeey@googlemail.com, sonic.zhang@analog.com, klaus.kudielka@ieee.org, t.sailer@alumni.ethz.ch, khilman@ti.com, eric.dumazet@gmail.com, jhovold@gmail.com, cyril@ti.com, rmk+kernel@arm.linux.org.uk, mingo@elte.hu, jpr@f6fbb.org, adobriyan@gmail.com, jreuter@yaina.de, cbe-oss-dev@lists.ozlabs.org, martinez.javier@gmail.com, samuel@sortiz.org, vapier@gentoo.org, grundler@parisc-linux.org, tklauser@distanz.ch, lucas.demarchi@profusion.mobi, u.kleine-koenig@pengutronix.de, olof@lixom.net, uclinux-dist-devel@blackfin.uclinux.org, linux-hams@vger.kernel.org, leitao@linux.vnet.ibm.com, blogic@openwrt.org, shawn.guo@linaro.org, nico@fluxnic.net, geoff@infradead.org, jkosina@suse.cz, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, ralph.hempel@lantiq.com, jdmason@kudzu.us, joe@perches.com, steve.glendinning@smsc.com, richard.cochran@omicron.at, linuxppc-dev@lists.ozlabs.org, David Miller Reply-To: Yong Zhang List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Sep 07, 2011 at 08:03:14PM +0200, Thomas Gleixner wrote: > On Wed, 7 Sep 2011, David Miller wrote: > > > From: Thomas Gleixner > > Date: Wed, 7 Sep 2011 19:32:39 +0200 (CEST) > > > > > On Wed, 7 Sep 2011, David Miller wrote: > > > > > >> From: Yong Zhang > > >> Date: Wed, 7 Sep 2011 16:10:42 +0800 > > >> > > >> > This flag is a NOOP and can be removed now. > > >> > > > >> > Signed-off-by: Yong Zhang > > >> > > >> I have the same concerns here as I had for the sparc case. > > >> > > >> Some of these drivers might be using IRQF_DISABLED to make sure the > > >> IRQ cannot be delivered until it is explicitly enabled via an > > >> enable_irq() call. > > >> > > >> How is that being accomodated now? > > > > > > Again IRQF_DISABLED never ever had that functionality. > > > > My bad. > > > > But what if these interrupts want interrupts disabled during their > > interrupt handler, for other reasons? > > We run ALL interrupt handlers with irqs disabled always. > > > This has the potential to break tons of stuff, especially on the > > really old chips which almost no developers have any more but some > > user might try to use. > > It won't. We removed IRQF_DISABLED from kernel/irq/* long ago Yeah, and this is why we say it's a NOOP now :) Thanks, Yong