From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] v4l: Remove experimental note from ENUM_FRAMESIZES and ENUM_FRAMEINTERVALS
Date: Thu, 8 Sep 2011 18:22:02 +0200 [thread overview]
Message-ID: <201109081822.02491.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20110903072612.GG13242@valkosipuli.localdomain>
Hi Sakari,
On Saturday 03 September 2011 09:26:12 Sakari Ailus wrote:
> On Sat, Sep 03, 2011 at 01:28:28AM +0300, Sakari Ailus wrote:
> > VIDIOC_ENUM_FRAMESIZES and VIDIOC_FRAME_INTERVALS have existed for quite
> > some time, are widely supported by various drivers and are being used by
> > applications. Thus they no longer can be considered experimental.
>
> I mostly intended to send this as RFC/PATCH (but forgot to give right
> options to git format-patch) to provoke a little bit discussion on how we
> should remove the experimental tags from features. These two ioctls are
> such that I'm aware are relatively widely used. No idea about the rest.
I agree with the removal of the experimental note. Those ioctls are widely
used by webcam (and other) applications and have been available for quite some
time now.
This being said, I'm not sure if I would design them the same way today. They
have clear UVC roots, and I would likely merge V4L2_FRMSIZE_TYPE_CONTINUOUS
and V4L2_FRMSIZE_TYPE_STEPWISE in a single type for instance. Howevern given
the wide user base, I don't think it would be a good idea to break the API and
ABI, even though both ioctls are currently experimental.
> > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> > ---
> >
> > Documentation/DocBook/media/v4l/compat.xml | 4 ----
> > .../DocBook/media/v4l/vidioc-enum-framesizes.xml | 7 -------
> > 2 files changed, 0 insertions(+), 11 deletions(-)
> >
> > diff --git a/Documentation/DocBook/media/v4l/compat.xml
> > b/Documentation/DocBook/media/v4l/compat.xml index ce1004a..a6261c1
> > 100644
> > --- a/Documentation/DocBook/media/v4l/compat.xml
> > +++ b/Documentation/DocBook/media/v4l/compat.xml
> > @@ -2458,10 +2458,6 @@ and may change in the future.</para>
> >
> > &VIDIOC-QUERYCAP; ioctl, <xref linkend="device-capabilities" />.</para>
> >
> > </listitem>
> > <listitem>
> >
> > - <para>&VIDIOC-ENUM-FRAMESIZES; and
> > -&VIDIOC-ENUM-FRAMEINTERVALS; ioctls.</para>
> > - </listitem>
> > - <listitem>
> >
> > <para>&VIDIOC-G-ENC-INDEX; ioctl.</para>
> >
> > </listitem>
> > <listitem>
> >
> > diff --git a/Documentation/DocBook/media/v4l/vidioc-enum-framesizes.xml
> > b/Documentation/DocBook/media/v4l/vidioc-enum-framesizes.xml index
> > f77a13f..a78454b 100644
> > --- a/Documentation/DocBook/media/v4l/vidioc-enum-framesizes.xml
> > +++ b/Documentation/DocBook/media/v4l/vidioc-enum-framesizes.xml
> > @@ -50,13 +50,6 @@ and pixel format and receives a frame width and
> > height.</para>
> >
> > <refsect1>
> >
> > <title>Description</title>
> >
> > - <note>
> > - <title>Experimental</title>
> > -
> > - <para>This is an <link linkend="experimental">experimental</link>
> > -interface and may change in the future.</para>
> > - </note>
> > -
> >
> > <para>This ioctl allows applications to enumerate all frame sizes
> >
> > (&ie; width and height in pixels) that the device supports for the
> > given pixel format.</para>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2011-09-08 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 22:28 [PATCH] v4l: Remove experimental note from ENUM_FRAMESIZES and ENUM_FRAMEINTERVALS Sakari Ailus
2011-09-03 7:26 ` Sakari Ailus
2011-09-08 16:22 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109081822.02491.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.