All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl
Date: Thu, 8 Sep 2011 20:50:50 -0400	[thread overview]
Message-ID: <201109082050.51313.vapier@gentoo.org> (raw)
In-Reply-To: <20110907211003.BE225140875D@gemini.denx.de>

On Wednesday, September 07, 2011 17:10:03 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > NAK for a few reasons:
> >  - i dont see how this could possibly compile warning free
> >  - you never initialize "i", only added to it
> >  - you call va_start() inbetween variable decls
> 
> Could you _please_ accustom yourself to updating the status in
> patchwork to "changes requested"  when sending revierw comments like
> here?

be nice if patchwork itself would key off a tag we could use in our e-mails 
and auto set the status ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110908/6d7f6782/attachment.pgp 

  reply	other threads:[~2011-09-09  0:50 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 22:20 [U-Boot] [PATCH 0/7] Bootgraph.pl instrumentation support for UBoot Andrew Murray
2011-08-31 22:20 ` [U-Boot] [PATCH 1/7] Add bootgraph.pl script for generating a boot graph SVG file Andrew Murray
2011-08-31 22:20 ` [U-Boot] [PATCH 2/7] Add macros for recording init calls during UBoot execution Andrew Murray
2011-08-31 22:50   ` Mike Frysinger
2011-08-31 23:40     ` Andrew Murray
2011-08-31 22:20 ` [U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl Andrew Murray
2011-08-31 22:47   ` Mike Frysinger
2011-08-31 23:30     ` Andrew Murray
2011-08-31 23:38     ` Graeme Russ
2011-08-31 23:42       ` Andrew Murray
2011-09-07 21:10     ` Wolfgang Denk
2011-09-09  0:50       ` Mike Frysinger [this message]
2011-09-09  7:00         ` Wolfgang Denk
2011-08-31 22:20 ` [U-Boot] [PATCH 4/7] Add bootgraph instrumentation for ARM boards Andrew Murray
2011-08-31 22:20 ` [U-Boot] [PATCH 5/7] Add bootgraph instrumentation for bootm command Andrew Murray
2011-08-31 22:21 ` [U-Boot] [PATCH 6/7] Add bootgraph instrumentation for UBoot commands Andrew Murray
2011-08-31 22:21 ` [U-Boot] [PATCH 7/7] Add documentation for bootgraph.pl Andrew Murray
2011-08-31 22:47 ` [U-Boot] [PATCH 0/7] Bootgraph.pl instrumentation support for UBoot Mike Frysinger
2011-08-31 23:12   ` Simon Glass
2011-08-31 23:25     ` Andrew Murray
2011-08-31 23:32       ` Graeme Russ
2011-08-31 23:39         ` Simon Glass
2011-08-31 23:53           ` Andrew Murray
2011-09-10 12:40             ` Andrew Murray
2011-09-13  4:34               ` Simon Glass
2011-09-13  5:24                 ` Graeme Russ
2011-09-13 11:52                   ` Simon Glass
2011-09-13 12:01                     ` Graeme Russ
2011-09-13 12:22                       ` Simon Glass
2011-09-10 12:37 ` [U-Boot] [PATCH v2 1/7] Add bootgraph.pl script for generating a boot graph SVG file Andrew Murray
2011-09-10 12:37   ` [U-Boot] [PATCH v2 2/7] Add macros for recording init calls during UBoot execution Andrew Murray
2011-09-10 13:17     ` Andrew Murray
2011-09-18  2:16       ` Mike Frysinger
2011-09-10 12:37   ` [U-Boot] [PATCH v2 3/7] Add timing information to printf's for use with bootgraph.pl Andrew Murray
2011-09-18  2:10     ` Mike Frysinger
2011-09-10 12:37   ` [U-Boot] [PATCH v2 4/7] Add bootgraph instrumentation for ARM boards Andrew Murray
2011-09-18  2:11     ` Mike Frysinger
2011-10-06 21:37     ` Wolfgang Denk
2011-09-10 12:37   ` [U-Boot] [PATCH v2 5/7] Add bootgraph instrumentation for bootm command Andrew Murray
2011-09-10 12:37   ` [U-Boot] [PATCH v2 6/7] Add bootgraph instrumentation for UBoot commands Andrew Murray
2011-09-18  2:11     ` Mike Frysinger
2011-10-06 21:35     ` Wolfgang Denk
2011-09-10 12:37   ` [U-Boot] [PATCH v2 7/7] Add documentation for bootgraph.pl Andrew Murray
2011-10-06 21:38   ` [U-Boot] [PATCH v2 1/7] Add bootgraph.pl script for generating a boot graph SVG file Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109082050.51313.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.