From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-68.nebula.fi ([83.145.220.68]:39186 "EHLO smtp-68.nebula.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958Ab1IIQTo (ORCPT ); Fri, 9 Sep 2011 12:19:44 -0400 Date: Fri, 9 Sep 2011 19:19:40 +0300 From: Sakari Ailus To: "Hadli, Manjunath" Cc: LMML , dlos Subject: Re: [PATCH v2 0/8] RFC for Media Controller capture driver for DM365 Message-ID: <20110909161940.GJ1724@valkosipuli.localdomain> References: <1314630439-1122-1-git-send-email-manjunath.hadli@ti.com> <20110831213032.GT12368@valkosipuli.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, Sep 09, 2011 at 07:10:49PM +0530, Hadli, Manjunath wrote: > Hi Sakari, > > On Thu, Sep 01, 2011 at 03:00:32, Sakari Ailus wrote: > > Hi Manju, > > > > Do you have the media device grap that would be typical for this hardware produced by media-ctl? That can be converted to postscript using dotfile. > > > > this would make it a little easier to understan this driver. Thanks. > > Sure. But can you be a little more elaborate on how you need this > information? If you can tell me in little more detail about this that will > help me make the information in a way that everyone can understand. Preferrably in PostScript format so it's easy to visualise the layout of the hardware that the driver supports, as the OMAP 3 ISP example was. > Thanks and Regards, > -Manju > > > > > > On Mon, Aug 29, 2011 at 08:37:11PM +0530, Manjunath Hadli wrote: > > > changes from last patch set: > > > 1. Made changes based on Sakari's feedback mainly: > > > a. returned early to allow unindenting > > > b. reformatting to shift the code to left where possible > > > c. changed hex numbers to lower case > > > d. corrected the defines according to module names. > > > e. magic numbers removed. > > > f. changed non-integer returning functions to void > > > g. removed unwanted paranthses. > > > h. fixed error codes. > > > i. fixed some RESET_BIt code to what it was intended for. > > > 2. reorganized the header files to move the kernel-only headers along > > > with the c files and interface headers in the include folder. > > > > ... > > -- Sakari Ailus e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk