From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH] Fix repeatable Oops on container destroy with conntrack
Date: Mon, 12 Sep 2011 11:37:49 +0200
Message-ID: <20110912093749.GE2194@1984>
References: <2184C0CE5A5EDC94CDDA5053@Ximines.local>
 <20110912072524.GA2996@p183.telecom.by>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <netfilter-devel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20110912072524.GA2996@p183.telecom.by>
Sender: netfilter-devel-owner@vger.kernel.org
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Alex Bligh <alex@alex.org.uk>, netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Linux Containers <containers@lists.osdl.org>
List-Id: containers.vger.kernel.org

On Mon, Sep 12, 2011 at 10:25:24AM +0300, Alexey Dobriyan wrote:
> On Sat, Sep 10, 2011 at 07:48:43PM +0100, Alex Bligh wrote:
> > --- a/net/netfilter/nf_conntrack_netlink.c
> > +++ b/net/netfilter/nf_conntrack_netlink.c
> > @@ -570,6 +570,11 @@ ctnetlink_conntrack_event(unsigned int events, struct nf_ct_event *item)
> >  		return 0;
> > 
> >  	net = nf_ct_net(ct);
> > +
> > +	/* container deinit, netlink may have died before death_by_timeout */
> > +	if (!net->nfnl)
> > +		return 0;
> > +
> >  	if (!item->report && !nfnetlink_has_listeners(net, group))
> >  		return 0;
> 
> If this is correct fix, ->nfnl check should be folded into
> nfnetlink_has_listeners(), otherwise expectations aren't covered.

Agreed.