All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/9] iptables-save: remove binary dumping dead code
Date: Mon, 12 Sep 2011 20:52:06 +0200	[thread overview]
Message-ID: <20110912185206.GA4018@1984> (raw)
In-Reply-To: <alpine.LNX.2.01.1109121244070.32300@frira.zrqbmnf.qr>

On Mon, Sep 12, 2011 at 12:48:36PM +0200, Jan Engelhardt wrote:
> 
> On Monday 2011-09-12 11:32, Pablo Neira Ayuso wrote:
> >>  
> >> -static int show_binary = 0, show_counters = 0;
> >> +static int show_counters = 0;
> >>  
> >>  static const struct option options[] = {
> >> -	{.name = "binary",   .has_arg = false, .val = 'b'},
> >
> >Please, better something less agressive like displaying a message
> >telling "-b option was never implemented, ignoring it".
> >
> >So if anyone, for some strange reason, is using it, their scripts will
> >not break.
> >
> >I know this may sound a bit nitpicking but I think it's good to make
> >sure that we don't break anything.
> 
> I think we are not talking about the same thing. If you run
> `iptables-save -b`, the program will exit with status 1 without
> printing anything related to rules. (Outputs "binary NYI" which, if
> you happen to be able to resolve the acronym, expands to "not yet
> implemented")
> 
> How would that be any better than getting "invalid option: -B"?

Well, we'll hit that anyway once you remove -b option.

> It is "NYI". Given the issues with binary representations that have
> come up within the last 10 years so far, I doubt that we have a
> reason to offer wanting to dump the packed ruleset right now.

Fair enough, go ahead.

  reply	other threads:[~2011-09-12 18:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-11 15:35 iptables: libiptc, cleanups Jan Engelhardt
2011-09-11 15:35 ` [PATCH 1/9] libiptc: resolve compile failure Jan Engelhardt
2011-09-11 15:35 ` [PATCH 2/9] iptables-save: remove binary dumping dead code Jan Engelhardt
2011-09-12  9:32   ` Pablo Neira Ayuso
2011-09-12 10:48     ` Jan Engelhardt
2011-09-12 18:52       ` Pablo Neira Ayuso [this message]
2011-09-11 15:35 ` [PATCH 3/9] libiptc: remove unused HOOK_DROPPING thing Jan Engelhardt
2011-09-11 15:35 ` [PATCH 4/9] libiptc: combine common types Jan Engelhardt
2011-09-12  9:36   ` Pablo Neira Ayuso
2011-09-12 10:43     ` Jan Engelhardt
2011-09-12 18:38       ` Pablo Neira Ayuso
2011-09-11 15:35 ` [PATCH 5/9] libiptc: replace ipt_chainlabel by xt_chainlabel Jan Engelhardt
2011-09-11 15:35 ` [PATCH 6/9] libiptc: combine common types: _handle Jan Engelhardt
2011-09-11 15:35 ` [PATCH 7/9] src: resolve old macro names that are indirections Jan Engelhardt
2011-09-11 15:35 ` [PATCH 8/9] libiptc: use a family-invariant xtc_ops struct for code reduction Jan Engelhardt
2011-09-11 15:35 ` [PATCH 9/9] ip6tables-restore: make code look alike with iptables-restore Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110912185206.GA4018@1984 \
    --to=pablo@netfilter.org \
    --cc=jengelh@medozas.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.