All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Joerg Roedel <joro@8bytes.org>,
	"iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	Ohad Ben-Cohen <ohad@wizery.com>,
	David Woodhouse <dwmw2@infradead.org>,
	David Brown <davidb@codeaurora.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/10] Driver core: Add iommu_ops to bus_type
Date: Tue, 13 Sep 2011 18:21:26 +0200	[thread overview]
Message-ID: <20110913162126.GA6184@suse.de> (raw)
In-Reply-To: <20110913153811.GO11701@amd.com>

On Tue, Sep 13, 2011 at 05:38:11PM +0200, Roedel, Joerg wrote:
> On Tue, Sep 13, 2011 at 10:58:55AM -0400, Greg KH wrote:
> > On Tue, Sep 13, 2011 at 04:54:02PM +0200, Roedel, Joerg wrote:
> > > --- a/include/linux/device.h
> > > +++ b/include/linux/device.h
> > > @@ -22,6 +22,7 @@
> > >  #include <linux/types.h>
> > >  #include <linux/module.h>
> > >  #include <linux/pm.h>
> > > +#include <linux/iommu.h>
> > 
> > Ick, please don't add new #includes to device.h, it makes the whole
> > build slower.  Just pre-declare the structure and all should be fine.
> 
> Hmm, since linux/iommu.h provides 'struct iommu_ops', and this patch
> adds a 'struct iommu_ops' to 'struct bus_type', wouldn't a simple
> forward declaration make the bus_type incomplete in most other places?

No, just like it doesn't make iommu.h incomplete as you used a struct
bus_type there.

> To lower the impact I can move the 'struct iommu_ops' to a seperate
> header file instead.

No, that should not be necessary.

greg k-h

  reply	other threads:[~2011-09-13 16:21 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 15:41 [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type Joerg Roedel
2011-09-07 15:41 ` [PATCH 01/10] iommu/core: Define iommu_ops and register_iommu only with CONFIG_IOMMU_API Joerg Roedel
2011-09-07 15:41 ` [PATCH 02/10] Driver core: Add iommu_ops to bus_type Joerg Roedel
2011-09-07 18:47   ` Greg KH
2011-09-07 19:19     ` Joerg Roedel
2011-09-07 19:44       ` Greg KH
2011-09-07 20:37         ` Don Dutile
2011-09-08  8:58           ` Joerg Roedel
2011-09-08  8:41         ` Joerg Roedel
2011-09-12 11:40           ` Sethi Varun-B16395
2011-09-13 14:54         ` Roedel, Joerg
2011-09-13 14:58           ` Greg KH
2011-09-13 15:15             ` Roedel, Joerg
2011-09-13 15:38             ` Roedel, Joerg
2011-09-13 16:21               ` Greg KH [this message]
2011-09-14 12:46                 ` Roedel, Joerg
2011-09-12 12:08       ` Sethi Varun-B16395
2011-09-12 12:35         ` Roedel, Joerg
2011-09-15 12:45           ` Sethi Varun-B16395
2011-09-15 13:13             ` Roedel, Joerg
2011-09-07 15:41 ` [PATCH 03/10] iommu/core: Add bus_type parameter to iommu_domain_alloc Joerg Roedel
2011-09-12 11:50   ` Sethi Varun-B16395
2011-09-12 12:37     ` Roedel, Joerg
2011-09-07 15:41 ` [PATCH 04/10] iommu/core: Convert iommu_found to iommu_present Joerg Roedel
2011-09-07 15:41 ` [PATCH 05/10] iommu/core: Use bus->iommu_ops in the iommu-api Joerg Roedel
2011-09-07 15:41 ` [PATCH 06/10] iommu/amd: Use bus_set_iommu instead of register_iommu Joerg Roedel
2011-09-07 15:41 ` [PATCH 07/10] iommu/vt-d: " Joerg Roedel
2011-09-07 15:41 ` [PATCH 08/10] iommu/omap: " Joerg Roedel
2011-09-07 15:41 ` [PATCH 09/10] iommu/msm: " Joerg Roedel
2011-09-07 15:41 ` [PATCH 10/10] iommu/core: Remove global iommu_ops and register_iommu Joerg Roedel
2011-09-07 18:48 ` [PATCH 0/10] IOMMU: Make iommu_ops per-bus_type Greg KH
2011-09-07 19:29   ` Joerg Roedel
2011-09-22 16:14 [PATCH 0/10 v2] " Joerg Roedel
2011-09-22 16:14 ` [PATCH 02/10] Driver core: Add iommu_ops to bus_type Joerg Roedel
2011-09-22 20:11   ` Greg KH
2011-09-23 15:19     ` Roedel, Joerg
2011-09-23 15:45 [PATCH 0/10 v3] IOMMU: Make iommu_ops per-bus_type Joerg Roedel
2011-09-23 15:45 ` [PATCH 02/10] Driver core: Add iommu_ops to bus_type Joerg Roedel
2011-09-29 20:05   ` Greg KH
2011-09-30  6:24     ` Joerg Roedel
2011-09-30 13:58       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110913162126.GA6184@suse.de \
    --to=gregkh@suse.de \
    --cc=Joerg.Roedel@amd.com \
    --cc=alex.williamson@redhat.com \
    --cc=davidb@codeaurora.org \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.