All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Kevin McNeely <kev@cypress.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support
Date: Wed, 14 Sep 2011 09:46:21 +0200	[thread overview]
Message-ID: <20110914074621.GA3582@polaris.bitmath.org> (raw)
In-Reply-To: <CAAwP0s0FvkzTUo5kAZE_pd_8u-znDvoLks74gf8+75cUF0aM2g@mail.gmail.com>

> > Compared to the staging version you sent earlier, this version seems
> > to be a step back towards the original version regarding the MT
> > implementation. Is this the right patch?
> 
> Hello Henrik,
> 
> Yes it is the right patch, or at least the patch I meant to send. The
> staging version I send earlier didn't support multi-touch protocol
> type A.

I see - the cyttsp_xydata struct seems to be the old version,
though. Any particular reason for that? Also, the similarity to the
problem found here, https://lkml.org/lkml/2011/8/25/516, suggests your
16 tracking ids could be mapped directly to slots instead, using the
example code. It ought to reduce the present patch significantly.

Thanks,
Henrik

  reply	other threads:[~2011-09-14  7:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-03  5:50 [PATCH V2 0/3] Input: Cypress TTSP device driver Javier Martinez Canillas
2011-09-03  5:50 ` [PATCH V2 1/3] Input: cyttsp - Cypress TTSP capacitive multi-touch screen support Javier Martinez Canillas
2011-09-13  8:24   ` Henrik Rydberg
2011-09-14  7:14     ` Javier Martinez Canillas
2011-09-14  7:14       ` Javier Martinez Canillas
2011-09-14  7:46       ` Henrik Rydberg [this message]
2011-09-14 21:03         ` Javier Martinez Canillas
2011-09-14 21:03           ` Javier Martinez Canillas
2011-09-14 10:50   ` Mohan Pallaka
2011-09-14 22:32     ` Javier Martinez Canillas
2011-09-14 22:32       ` Javier Martinez Canillas
2011-09-03  5:50 ` [PATCH V2 2/3] Input: cyttsp - add support for Cypress TTSP touchscreen I2C bus interface Javier Martinez Canillas
2011-09-03  5:50 ` [PATCH V2 3/3] Input: cyttsp - add support for Cypress TTSP touchscreen SPI " Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110914074621.GA3582@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@suse.de \
    --cc=kev@cypress.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.