All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	linux-raid@vger.kernel.org, dm-devel@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/2] block: refactor generic_make_request
Date: Thu, 15 Sep 2011 07:55:34 -0400	[thread overview]
Message-ID: <20110915115534.GA14819@infradead.org> (raw)
In-Reply-To: <20110912151310.GA7188@infradead.org>

On Mon, Sep 12, 2011 at 11:13:10AM -0400, Christoph Hellwig wrote:
> > > @@ -1557,16 +1561,15 @@ void generic_make_request(struct bio *bi
> > >  	 * from the top.  In this case we really did just take the bio
> > >  	 * of the top of the list (no pretending) and so remove it from
> > >  	 * bio_list, and call into __generic_make_request again.
> >                                    ^^^^^^^^^^
> > You got rid of __generic_make_request(). Now above comment has stale
> > reference to it.
> 
> Yeah, this should be ->make_request now.

Jens, do you want me to resend with that fix or can you fix it up when
applying?

  reply	other threads:[~2011-09-15 11:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-11 14:50 [PATCH 1/2] block: export __make_request Christoph Hellwig
2011-09-11 14:51 ` [PATCH 2/2] block: remove support for bio remapping from ->make_request Christoph Hellwig
2011-09-12  3:25   ` NeilBrown
2011-09-12  9:59   ` Jens Axboe
2011-09-12 12:25     ` Christoph Hellwig
2011-09-12 12:26       ` Jens Axboe
2011-09-12  9:59 ` [PATCH 1/2] block: export __make_request Jens Axboe
2011-09-12 12:25   ` Christoph Hellwig
2011-09-12 12:26     ` Jens Axboe
2011-09-12 13:38       ` Christoph Hellwig
2011-09-12 18:04         ` Jens Axboe
2011-09-13 21:19           ` Christoph Hellwig
2011-09-14 17:17             ` Boaz Harrosh
2011-09-14 17:17               ` Boaz Harrosh
2011-09-14 17:53               ` Doug Dumitru
2011-09-14 17:53                 ` Doug Dumitru
2011-09-14 18:40                 ` Alan Cox
2011-09-14 21:34                   ` Doug Dumitru
2011-09-14 22:01                     ` Alan Cox
2011-09-14 22:48                       ` Doug Dumitru
2011-09-15 10:20                     ` Bernd Petrovitsch
2011-09-14 20:16               ` Nicholas A. Bellinger
2011-09-12 13:42 ` [PATCH 3/2] block: refactor generic_make_request Christoph Hellwig
2011-09-12 15:09   ` Vivek Goyal
2011-09-12 15:13     ` Christoph Hellwig
2011-09-15 11:55       ` Christoph Hellwig [this message]
2011-09-15 11:56         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110915115534.GA14819@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.