All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] mfd wm8350: rename static gpio_set_debounce()
Date: Sat, 17 Sep 2011 10:57:15 +0200	[thread overview]
Message-ID: <20110917085715.GA5139@pengutronix.de> (raw)
In-Reply-To: <20110822101330.GL4607@sortiz-mobl>

Hi Samuel,

On Mon, Aug 22, 2011 at 12:13:30PM +0200, Samuel Ortiz wrote:
> On Wed, Aug 10, 2011 at 10:05:49AM +0200, Sascha Hauer wrote:
> > 
> > The kernel already has a function with this name declared
> > in asm-generic/gpio.h. So if this header leaks into wm8350/gpio.c
> > we get
> > 
> > drivers/mfd/wm8350-gpio.c:40:12: error: conflicting types for 'gpio_set_debounce'
> > include/asm-generic/gpio.h:156:12: note: previous declaration of 'gpio_set_debounce' was here
> > 
> > Fix this by adding a wm8350_ prefix to the function.
> Thanks for the fix, I applied this patch to both of my branches.
> I'll send a pull request for the MFD fixes soon.

Ping... could you try to move this forward?

The kernel doesn't compile for mx3_defconfig since more than 6 weeks now
because of this patch :-(

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2011-09-17  8:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  8:05 [PATCH] mfd wm8350: rename static gpio_set_debounce() Sascha Hauer
2011-08-10 10:41 ` Mark Brown
2011-08-15  6:34 ` Uwe Kleine-König
2011-08-15  6:34   ` Uwe Kleine-König
2011-08-19  9:53 ` Uwe Kleine-König
2011-08-19 21:58   ` Mark Brown
2011-08-19 23:47     ` Samuel Ortiz
2011-08-22 10:13 ` Samuel Ortiz
2011-09-17  8:57   ` Robert Schwebel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110917085715.GA5139@pengutronix.de \
    --to=r.schwebel@pengutronix.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.