All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: "Carlos Martín Nieto" <carlos@cmartin.tk>
Cc: "Frédéric Heitzmann" <frederic.heitzmann@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] git svn dcommit: new option --interactive.
Date: Sun, 18 Sep 2011 01:13:49 +0000	[thread overview]
Message-ID: <20110918011349.GA22037@dcvr.yhbt.net> (raw)
In-Reply-To: <1316261904.6897.9.camel@bee.lab.cmartin.tk>

Carlos Martín Nieto <carlos@cmartin.tk> wrote:
> On Fri, 2011-09-16 at 23:02 +0200, Frédéric Heitzmann wrote:
> > Allow the user to check the patch set before it is commited to SNV. It is
> 
> Typo: SNV -> SVN

Thanks, fixed locally

> My perl-foo isn't strong enough to properly review the rest.

I also squashed the following cleanup:

--- a/git-svn.perl
+++ b/git-svn.perl
@@ -802,7 +802,6 @@ sub cmd_dcommit {
 	if (defined $_interactive){
 		my $ask_default = "y";
 		foreach my $d (@$linear_refs){
-			print "debug : d = $d\n";
 			my ($fh, $ctx) = command_output_pipe(qw(show --summary), "$d");
 			while (<$fh>){
 				print $_;


Otherwise things good to me.  Acked and pushed out to master of
git://bogomips.org/git-svn.git

      parent reply	other threads:[~2011-09-18  1:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-16 21:02 [PATCH v3] git svn dcommit: new option --interactive Frédéric Heitzmann
2011-09-16 21:08 ` Junio C Hamano
2011-09-17 12:18 ` Carlos Martín Nieto
2011-09-17 13:11   ` Frédéric Heitzmann
2011-09-18  1:13   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110918011349.GA22037@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=carlos@cmartin.tk \
    --cc=frederic.heitzmann@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.