From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756857Ab1ISGBK (ORCPT ); Mon, 19 Sep 2011 02:01:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010Ab1ISGBI (ORCPT ); Mon, 19 Sep 2011 02:01:08 -0400 Date: Mon, 19 Sep 2011 09:01:50 +0300 From: "Michael S. Tsirkin" To: Rusty Russell Cc: Sasha Levin , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] virtio-net: Read MAC only after initializing MSI-X Message-ID: <20110919060150.GB1569@redhat.com> References: <1313225461-24458-1-git-send-email-levinsasha928@gmail.com> <20110819152335.GA19489@redhat.com> <1313771587.12243.16.camel@lappy> <20110820200043.GB5276@redhat.com> <871uvdryq2.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871uvdryq2.fsf@rustcorp.com.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 19, 2011 at 01:05:17PM +0930, Rusty Russell wrote: > On Sat, 20 Aug 2011 23:00:44 +0300, "Michael S. Tsirkin" wrote: > > On Fri, Aug 19, 2011 at 07:33:07PM +0300, Sasha Levin wrote: > > > Maybe this is better solved by copying the way it was done in PCI itself > > > with capability linked list? > > > > There are any number of ways to lay out the structure. I went for what > > seemed a simplest one. For MSI-X the train has left the station. We > > can probably still tweak where the high 32 bit features > > for 64 bit features are. No idea if it's worth it. > > Sorry, this has been in the back of my mind. I think it's a good idea; > can we use the capability linked list for pre-device specific stuff from > now on? > > Thanks, > Rusty. Do we even want capability bits then? We can give each capability an ack flag ... -- MST