From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Sterba Subject: Re: [PATCH] Btrfs: fix direct-io vs nodatacow Date: Thu, 22 Sep 2011 12:31:30 +0200 Message-ID: <20110922103130.GT22205@twin.jikos.cz> References: <4E6827EB.2030907@cn.fujitsu.com> Reply-To: dave@jikos.cz Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-btrfs@vger.kernel.org" To: Li Zefan Return-path: In-Reply-To: <4E6827EB.2030907@cn.fujitsu.com> List-ID: On Thu, Sep 08, 2011 at 10:26:51AM +0800, Li Zefan wrote: > To reproduce the bug: > > # mount -o nodatacow /dev/sda7 /mnt/ > # dd if=/dev/zero of=/mnt/tmp bs=4K count=1 > 1+0 records in > 1+0 records out > 4096 bytes (4.1 kB) copied, 0.000136115 s, 30.1 MB/s > # dd if=/dev/zero of=/mnt/tmp bs=4K count=1 conv=notrunc oflag=direct > dd: writing `/mnt/tmp': Input/output error > 1+0 records in > 0+0 records out > > btrfs_ordered_update_i_size() may return 1, but btrfs_endio_direct_write() > mistakenly takes it as an error. > > Signed-off-by: Li Zefan Reviewed-by: David Sterba > --- > fs/btrfs/inode.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c > index 0ccc743..3bd35fe 100644 > --- a/fs/btrfs/inode.c > +++ b/fs/btrfs/inode.c > @@ -5785,8 +5785,7 @@ again: > if (test_bit(BTRFS_ORDERED_NOCOW, &ordered->flags)) { > ret = btrfs_ordered_update_i_size(inode, 0, ordered); > if (!ret) > - ret = btrfs_update_inode(trans, root, inode); > - err = ret; > + err = btrfs_update_inode(trans, root, inode); > goto out; > } > > -- 1.7.3.1 > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html