From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin O'Connor Subject: Re: [PATCH 0/4] acpi: fix up EJ0 in DSDT Date: Thu, 22 Sep 2011 08:39:30 -0400 Message-ID: <20110922123930.GA15441@morn.localdomain> References: <20110922043513.GA488@morn.localdomain> <20110922060948.GA29819@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Amos Kong , seabios@seabios.org, Gleb Natapov , kvm@vger.kernel.org, jasowang@redhat.com, alex williamson , Marcelo Tosatti To: "Michael S. Tsirkin" Return-path: Received: from mail-vx0-f174.google.com ([209.85.220.174]:48487 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145Ab1IVMje (ORCPT ); Thu, 22 Sep 2011 08:39:34 -0400 Received: by vcbfk10 with SMTP id fk10so409746vcb.19 for ; Thu, 22 Sep 2011 05:39:34 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20110922060948.GA29819@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Sep 22, 2011 at 09:09:49AM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 22, 2011 at 12:35:13AM -0400, Kevin O'Connor wrote: > > On Wed, Sep 21, 2011 at 03:44:13PM +0300, Michael S. Tsirkin wrote: > > > The correct way to suppress hotplug is not to have _EJ0, > > > so this is what this patch does: it probes PIIX and > > > modifies DSDT to match. > > > > The code to generate basic SSDT code isn't that difficult (see > > build_ssdt and src/ssdt-proc.dsl). Is there a compelling reason to > > patch the DSDT versus just generating the necessary blocks in an SSDT? > > I don't really care whether the code is in DSDT or SSDT, > IMO there isn't much difference between build_ssdt and patching: > main reason is build_ssdt uses offsets hardcoded to a specific binary > (ssdt_proc and SD_OFFSET_* ) while I used > a script to extract offsets. > > I think we should avoid relying on copy-pasted binary > because I see the related ASL code changing in the near future > (with multifunction and bridge support among others). > > I can generalize the approach though, so that > it can work for finding arbitrary names > without writing more scripts, hopefully with the > potential to address the hard-coded offsets in acpi.c > as well. Does that sound interesting? Replacing the hardcoding of offsets in src/ssdt-proc.dsl would be nice. I'll take a look at your new patches tonight. -Kevin