From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3 04/17] crypto: Add userspace configuration API
Date: Mon, 26 Sep 2011 12:56:46 +0200 [thread overview]
Message-ID: <20110926105646.GZ1808@secunet.com> (raw)
In-Reply-To: <20110921090238.GI1808@secunet.com>
On Wed, Sep 21, 2011 at 11:02:38AM +0200, Steffen Klassert wrote:
> +
> +static int crypto_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
> +{
> + struct nlattr *attrs[CRYPTOCFGA_MAX+1];
> + struct crypto_link *link;
> + int type, err;
> +
> + type = nlh->nlmsg_type;
> + if (type > CRYPTO_MSG_MAX)
> + return -EINVAL;
> +
> + type -= CRYPTO_MSG_BASE;
> + link = &crypto_dispatch[type];
> +
> + if (security_netlink_recv(skb, CAP_NET_ADMIN))
> + return -EPERM;
> +
I'm just wondering whether CAP_NET_ADMIN is the right capability to
use here? Do you think we can keep it like that, or would it be better
to define a new CAP_CRYPTO_ADMIN capability?
next prev parent reply other threads:[~2011-09-26 10:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 8:58 [PATCH v3 00/17] crypto user configuration api Steffen Klassert
2011-09-21 8:59 ` [PATCH v3 01/17] crypto: Add a flag to identify crypto instances Steffen Klassert
2011-09-21 9:00 ` [PATCH v3 02/17] crypto: Export crypto_remove_spawns Steffen Klassert
2011-09-21 9:01 ` [PATCH v3 03/17] crypto: Export crypto_remove_final Steffen Klassert
2011-09-21 9:02 ` [PATCH v3 04/17] crypto: Add userspace configuration API Steffen Klassert
2011-09-23 5:55 ` Herbert Xu
2011-09-23 8:37 ` Steffen Klassert
2011-09-26 10:56 ` Steffen Klassert [this message]
2011-09-26 11:21 ` Herbert Xu
2011-09-21 9:03 ` [PATCH v3 05/17] crypto: Add a report function pointer to crypto_typ Steffen Klassert
2011-09-21 9:04 ` [PATCH v3 06/17] crypto: Add userspace report for larval type algorithms Steffen Klassert
2011-09-21 9:04 ` [PATCH v3 07/17] crypto: Add userspace report for shash " Steffen Klassert
2011-09-21 9:05 ` [PATCH v3 08/17] crypto: Add userspace report for ahash " Steffen Klassert
2011-09-21 9:06 ` [PATCH v3 09/17] crypto: Add userspace report for blkcipher " Steffen Klassert
2011-09-21 9:07 ` [PATCH v3 10/17] crypto: Add userspace report for ablkcipher " Steffen Klassert
2011-09-24 3:21 ` Herbert Xu
2011-09-26 5:35 ` Steffen Klassert
2011-09-21 9:08 ` [PATCH v3 11/17] crypto: Add userspace report for givcipher " Steffen Klassert
2011-09-21 9:08 ` [PATCH v3 12/17] crypto: Add userspace report for aead " Steffen Klassert
2011-09-21 9:09 ` [PATCH v3 13/17] crypto: Add userspace report for nivaead " Steffen Klassert
2011-09-21 9:10 ` [PATCH v3 14/17] crypto: Add userspace report for pcompress " Steffen Klassert
2011-09-21 9:11 ` [PATCH v3 15/17] crypto: Add userspace report for rng " Steffen Klassert
2011-09-21 9:11 ` [PATCH 16/17] crypto: Add userspace report for cipher " Steffen Klassert
2011-09-21 9:12 ` [PATCH v3 17/17] crypto: Add userspace report for compress " Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926105646.GZ1808@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.