All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Matthias Dellweg <2500@gmx.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb/core/devio.c: Check for printer class specific request
Date: Mon, 26 Sep 2011 15:34:30 -0700	[thread overview]
Message-ID: <20110926223430.GA21960@kroah.com> (raw)
In-Reply-To: <20110925144651.0ed3daaf@horus>

On Sun, Sep 25, 2011 at 02:46:51PM +0200, Matthias Dellweg wrote:
> From: Matthias Dellweg <2500@gmx.de>
> 
> In the usb printer class specific request get_device_id the value of
> wIndex is (interface << 8 | altsetting) instead of just interface.
> This enables the detection of some printers with libusb.
> 
> The hardware I tested this patch with is a Prolific
> USB->Centronics cable (067b:2305).
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Matthias Dellweg <2500@gmx.de>
> Cc: stable <stable@kernel.org>
> ---
>  drivers/usb/core/devio.c |   21 ++++++++++++++++++---
>  1 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index 37518df..1d73709 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -607,9 +607,10 @@ static int findintfep(struct usb_device *dev, unsigned int ep)
>  }
>  
>  static int check_ctrlrecip(struct dev_state *ps, unsigned int requesttype,
> -                          unsigned int index)
> +                          unsigned int request, unsigned int index)
>  {
>         int ret = 0;
> +       struct usb_host_interface *alt_setting;
>  
>         if (ps->dev->state != USB_STATE_UNAUTHENTICATED
>          && ps->dev->state != USB_STATE_ADDRESS

All of the tabs were stripped out of this email, making it impossible to
apply it :(

Care to fix this up and resend it so that I can apply it?

thanks,

greg k-h

  reply	other threads:[~2011-09-26 22:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22 10:10 [PATCH] enable usb control message with class specific request Matthias Dellweg
2011-09-22 15:12 ` Alan Stern
2011-09-22 21:56   ` Matthias Dellweg
2011-09-23  7:05     ` Matthias Dellweg
2011-09-23 16:16       ` Alan Stern
2011-09-23 17:57         ` Matthias Dellweg
2011-09-23 18:31           ` Alan Stern
2011-09-25 12:46             ` Matthias Dellweg
2011-09-26 22:34               ` Greg KH [this message]
2011-09-26 23:24                 ` [PATCH] usb/core/devio.c: Check for printer " Matthias Dellweg
2011-09-26 23:31                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110926223430.GA21960@kroah.com \
    --to=greg@kroah.com \
    --cc=2500@gmx.de \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.