From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 4/9] regulator: twl: Make twl-regulator driver extract data from DT Date: Tue, 27 Sep 2011 13:14:15 +0100 Message-ID: <20110927121415.GC4289@opensource.wolfsonmicro.com> References: <1317118372-17052-1-git-send-email-rnayak@ti.com> <1317118372-17052-5-git-send-email-rnayak@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1317118372-17052-5-git-send-email-rnayak@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Rajendra Nayak Cc: grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tony@atomide.com, lrg@ti.com, b-cousson@ti.com, patches@linaro.org List-Id: devicetree@vger.kernel.org On Tue, Sep 27, 2011 at 03:42:47PM +0530, Rajendra Nayak wrote: > +#ifdef CONFIG_OF > + char compatible[128]; > +#endif Might it not be better to just make this a pointer to const char? From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Tue, 27 Sep 2011 13:14:15 +0100 Subject: [PATCH 4/9] regulator: twl: Make twl-regulator driver extract data from DT In-Reply-To: <1317118372-17052-5-git-send-email-rnayak@ti.com> References: <1317118372-17052-1-git-send-email-rnayak@ti.com> <1317118372-17052-5-git-send-email-rnayak@ti.com> Message-ID: <20110927121415.GC4289@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 27, 2011 at 03:42:47PM +0530, Rajendra Nayak wrote: > +#ifdef CONFIG_OF > + char compatible[128]; > +#endif Might it not be better to just make this a pointer to const char?