From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
Date: Tue, 27 Sep 2011 23:51:45 +0200 [thread overview]
Message-ID: <20110927235145.544b91ee@skate> (raw)
In-Reply-To: <0056cd290aa1be1559ccdd6b3877927fe51ecbe0.1317023087.git.baruch@tkos.co.il>
Baruch,
Le Mon, 26 Sep 2011 10:48:57 +0300,
Baruch Siach <baruch@tkos.co.il> a ?crit :
> The "" string is not equal to the empty string. This fixes build
> errors like:
>
> arm-none-linux-gnueabi-gcc: : No such file or directory
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
For some reason, your patch does not seem to apply on current master.
> # march/mtune/floating point mode needs to be passed to the external toolchain
> # to select the right multilib variant
> -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
Should be use TOOLCHAIN_EXTERNAL_CUSTOM_ARGS in these two lines
instead ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-09-27 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 7:48 [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
2011-09-27 21:51 ` Thomas Petazzoni [this message]
2011-10-02 6:22 ` Baruch Siach
2011-10-02 6:50 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927235145.544b91ee@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.