All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/3] ASoC: omap-mcbsp: Prepare for init time DAI format setting
Date: Fri, 30 Sep 2011 15:00:38 +0100	[thread overview]
Message-ID: <20110930140038.GG2085@sirena.org.uk> (raw)
In-Reply-To: <1317388066-28443-1-git-send-email-jarkko.nikula@bitmer.com>

On Fri, Sep 30, 2011 at 04:07:44PM +0300, Jarkko Nikula wrote:
> Before commit 75d9ac4 ("ASoC: Allow DAI formats to be specified in the
> dai_link") expectation for omap-mcbsp was that snd_soc_dai_set_fmt is to be
> called first in machine hw_params callback before other CPU DAI functions.
> Thus it was enough that only omap_mcbsp_dai_set_dai_fmt cleared the
> mcbsp->regs structure.

> Now this doesn't hold anymore since machine drivers can set the DAI format
> only once on init time and thus mcbsp->regs may get out of sync when other

Note that it's only been convention that stopped this happening in the
past, there's never been anything stopping drivers doing this in the
link init function.

  parent reply	other threads:[~2011-09-30 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 13:07 [PATCH 1/3] ASoC: omap-mcbsp: Prepare for init time DAI format setting Jarkko Nikula
2011-09-30 13:07 ` [PATCH 2/3] ASoC: omap: Convert bunch of machine drivers to use init time DAI format Jarkko Nikula
2011-09-30 13:07 ` [PATCH 3/3] ASoC: omap: Use single hw_params callback in sdp3430 and zoom2 Jarkko Nikula
2011-09-30 14:00 ` Mark Brown [this message]
2011-10-02 18:51 ` [PATCH 1/3] ASoC: omap-mcbsp: Prepare for init time DAI format setting Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110930140038.GG2085@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lrg@ti.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.