From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Date: Fri, 30 Sep 2011 16:46:41 +0000 Subject: Re: [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read_value() (v2) Message-Id: <201109301846.41364.rjw@sisk.pl> List-Id: References: <201108310017.03103.rjw@sisk.pl> <201109292233.52378.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jean Pihet Cc: Linux PM mailing list , LKML , Linux-sh list , Magnus Damm , Kevin Hilman , Ming Lei On Friday, September 30, 2011, Jean Pihet wrote: > Hi Rafael, > > On Thu, Sep 29, 2011 at 10:33 PM, Rafael J. Wysocki wrote: > > Hi, > > > > On Thursday, September 29, 2011, Jean Pihet wrote: > >> Hi Rafael, > >> > >> I have a few minor remarks, inlined below. > > > > In the meantime it turned out that the patch caused a build failure > > for CONFIG_PM_SLEEP unset (your original patches won't really work > > in this case too), so I posted a patch to fix it. However, since > > you had remarks anyway, I've simply folded the fix into the next > > version of the $subject patch, which is appended. > OK to me. > > I have 2 remarks though: > - some drivers are using the power_state field in the suspend/resume > operation, IIUC without conflict. Can you confirm? Yes, I can. There are no conflicts. > - the power_state field is scheduled for removal, cf. > Documentation/feature-removal-schedule.txt. That does not look > correct. It still is schediled for removal, but we can't remove it right now anyway because of the users mentioned above. I'll replace this field with a one-bit flag when we're ready to drop it (some time in future). Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562Ab1I3Qo3 (ORCPT ); Fri, 30 Sep 2011 12:44:29 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:39967 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119Ab1I3Qo1 (ORCPT ); Fri, 30 Sep 2011 12:44:27 -0400 From: "Rafael J. Wysocki" To: Jean Pihet Subject: Re: [PATCH 3/3] PM / QoS: Add function dev_pm_qos_read_value() (v2) Date: Fri, 30 Sep 2011 18:46:41 +0200 User-Agent: KMail/1.13.6 (Linux/3.1.0-rc8+; KDE/4.6.0; x86_64; ; ) Cc: Linux PM mailing list , LKML , "Linux-sh list" , Magnus Damm , Kevin Hilman , Ming Lei References: <201108310017.03103.rjw@sisk.pl> <201109292233.52378.rjw@sisk.pl> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201109301846.41364.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, September 30, 2011, Jean Pihet wrote: > Hi Rafael, > > On Thu, Sep 29, 2011 at 10:33 PM, Rafael J. Wysocki wrote: > > Hi, > > > > On Thursday, September 29, 2011, Jean Pihet wrote: > >> Hi Rafael, > >> > >> I have a few minor remarks, inlined below. > > > > In the meantime it turned out that the patch caused a build failure > > for CONFIG_PM_SLEEP unset (your original patches won't really work > > in this case too), so I posted a patch to fix it. However, since > > you had remarks anyway, I've simply folded the fix into the next > > version of the $subject patch, which is appended. > OK to me. > > I have 2 remarks though: > - some drivers are using the power_state field in the suspend/resume > operation, IIUC without conflict. Can you confirm? Yes, I can. There are no conflicts. > - the power_state field is scheduled for removal, cf. > Documentation/feature-removal-schedule.txt. That does not look > correct. It still is schediled for removal, but we can't remove it right now anyway because of the users mentioned above. I'll replace this field with a one-bit flag when we're ready to drop it (some time in future). Thanks, Rafael