From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: [PATCH 1/2] bridge: leave carrier on for empty bridge Date: Mon, 03 Oct 2011 21:14:45 -0700 Message-ID: <20111004041509.191082289@vyatta.com> References: <20111004041444.793960297@vyatta.com> Cc: netdev@vger.kernel.org To: "David S. Miller" Return-path: Received: from sfca-50.vyatta.com ([76.74.103.50]:33109 "EHLO fiji.vyatta.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750966Ab1JDEQw (ORCPT ); Tue, 4 Oct 2011 00:16:52 -0400 Content-Disposition: inline; filename=br-carrier-default.patch Sender: netdev-owner@vger.kernel.org List-ID: This resolves a regression seen by some users of bridging. Some users use the bridge like a dummy device. They expect to be able to put an IPv6 address on the device with no ports attached. Although there are better ways of doing this, there is no reason to not allow it. Note: the bridge still will reflect the state of ports in the bridge if there are any added. Signed-off-by: Stephen Hemminger --- This fix needs to go to stable as well since it has been reported as a regression. --- a/net/bridge/br_device.c 2011-09-01 08:52:27.596631192 -0700 +++ b/net/bridge/br_device.c 2011-09-01 09:01:03.256611801 -0700 @@ -91,7 +91,6 @@ static int br_dev_open(struct net_device { struct net_bridge *br = netdev_priv(dev); - netif_carrier_off(dev); netdev_update_features(dev); netif_start_queue(dev); br_stp_enable_bridge(br); @@ -108,8 +107,6 @@ static int br_dev_stop(struct net_device { struct net_bridge *br = netdev_priv(dev); - netif_carrier_off(dev); - br_stp_disable_bridge(br); br_multicast_stop(br);