From: Catalin Marinas <catalin.marinas@arm.com>
To: Tejun Heo <htejun@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Huajun Li <huajun.li.lee@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 2/4] kmemleak: Handle percpu memory allocation
Date: Tue, 4 Oct 2011 10:04:46 +0100 [thread overview]
Message-ID: <20111004090446.GA10071@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <20111004075915.GE15637@dhcp-172-17-108-109.mtv.corp.google.com>
On Tue, Oct 04, 2011 at 08:59:15AM +0100, Tejun Heo wrote:
> On Mon, Oct 03, 2011 at 04:21:26PM +0100, Catalin Marinas wrote:
> > The updated patch below adds specific kmemleak API for percpu pointers
> > so that it only logs one call per allocation rather than the number of
> > possible cpus (could be split in two, though the patch is relatively
> > simple):
>
> The percpu part looks fine to me but I don't know how kmemleak works
> to judge whether the kmemleak part is okay or not. This just avoids
> false positives from slab and would still require bumping up the early
> log memory as # of cpus increases, right?
No, there is only one kmemleak call for each __percpu pointer (to the
specific kmemleak_*_percpu function). The kmemleak expands the percpu
pointer into corresponding blocks for each cpu but the early log only
stores a single call.
> For percpu part,
>
> Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
> How do you want to route this? If kmemleak patches get routed through
> -mm, please feel free to send it to Andrew with Acked-by's added.
I'll push them to -next for now and (depending on how late the merge
window opens) I can send a pull request to Linus.
--
Catalin
next prev parent reply other threads:[~2011-10-04 9:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 11:02 [PATCH 0/4] Kmemleak patches for -next Catalin Marinas
2011-09-29 11:02 ` [PATCH 1/4] kmemleak: Show where early_log issues come from Catalin Marinas
2011-09-29 11:02 ` [PATCH 2/4] kmemleak: Handle percpu memory allocation Catalin Marinas
2011-09-29 11:56 ` Eric Dumazet
2011-09-29 17:17 ` Catalin Marinas
2011-09-29 17:57 ` Christoph Lameter
2011-09-29 19:28 ` Tejun Heo
2011-09-30 8:37 ` Catalin Marinas
2011-10-03 15:21 ` Catalin Marinas
2011-10-03 16:14 ` Christoph Lameter
2011-10-04 7:59 ` Tejun Heo
2011-10-04 9:04 ` Catalin Marinas [this message]
2011-10-04 9:13 ` Tejun Heo
2011-10-04 9:26 ` Catalin Marinas
2011-10-04 16:59 ` Tejun Heo
2011-10-04 17:06 ` Catalin Marinas
2011-09-29 11:02 ` [PATCH 3/4] kmemleak: When the early log buffer is exceeded, report the actual number Catalin Marinas
2011-09-29 11:02 ` [PATCH 4/4] kmemleak: Report previously found leaks even after an error Catalin Marinas
2011-10-04 17:45 ` Nick Bowler
2011-10-04 20:50 ` Catalin Marinas
2011-10-04 21:14 ` Nick Bowler
2011-10-24 18:57 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004090446.GA10071@e102109-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=cl@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=huajun.li.lee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.