From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Please help with the OMAP static mapping mess Date: Tue, 4 Oct 2011 10:50:57 -0700 Message-ID: <20111004175057.GU6324@atomide.com> References: <20111003205658.GJ6324@atomide.com> <20111003225908.GL6324@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:33794 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932845Ab1JDRvC (ORCPT ); Tue, 4 Oct 2011 13:51:02 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nicolas Pitre * Shilimkar, Santosh [111003 22:45]: > On Tue, Oct 4, 2011 at 4:29 AM, Tony Lindgren wrot= e: > > * Nicolas Pitre [111003 15:05]: > >> On Mon, 3 Oct 2011, Nicolas Pitre wrote: > >> > >> > On Mon, 3 Oct 2011, Tony Lindgren wrote: > >> > > >> > > * Nicolas Pitre [111003 11:26]: > >> > > > > >> > > > Furthermore... there is also a static mapping for physical a= ddress > >> > > > 0x4e000000 using virtual address 0xff100000 which is already= reserved > >> > > > for other purposes i.e. the consistent DMA area. =C2=A0It is= not immediately > >> > > > obvious where this comes from without being intimate with th= e OMAP code. > >> > > > Can this be fixed as well i.e. moved elsewhere please? > >> > > > >> > > This sounds like a bug somewhere. Which omap are you seeing th= is on? > >> > > >> > OMAP4430 on a Panda board. > >> > > >> > Here are the static mappings I'm seeing: > >> > > >> > phys =3D 0x44000000 virt =3D 0xf8000000 size =3D 0x100000 > >> > phys =3D 0x4a000000 virt =3D 0xfc000000 size =3D 0x400000 > >> > phys =3D 0x50000000 virt =3D 0xf9000000 size =3D 0x100000 > >> > phys =3D 0x4c000000 virt =3D 0xfd100000 size =3D 0x100000 > >> > phys =3D 0x4d000000 virt =3D 0xfe100000 size =3D 0x100000 > >> > phys =3D 0x4e000000 virt =3D 0xff100000 size =3D 0x100000 <--- > >> > phys =3D 0x48000000 virt =3D 0xfa000000 size =3D 0x400000 > >> > phys =3D 0x54000000 virt =3D 0xfe800000 size =3D 0x800000 > >> > >> It looks like this comes from OMAP44XX_DMM_VIRT. > >> > >> #define OMAP44XX_DMM_PHYS =C2=A0 =C2=A0 =C2=A0 OMAP44XX_DMM_BASE > >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* 0x4e000000 --> 0xfd300000 */ > >> #define OMAP44XX_DMM_VIRT =C2=A0 =C2=A0 =C2=A0 (OMAP44XX_DMM_PHYS = + OMAP4_L3_PER_IO_OFFSET) > >> #define OMAP44XX_DMM_SIZE =C2=A0 =C2=A0 =C2=A0 SZ_1M > >> > >> The comment suggesting a mapping correspondance is obviously wrong= =2E We have: > >> > >> #define OMAP44XX_DMM_BASE =C2=A0 =C2=A0 =C2=A0 0x4e000000 > >> #define OMAP4_L3_PER_IO_OFFSET =C2=A00xb1100000 > >> > >> Hence 0x4e000000 + 0xb1100000 =3D 0xff100000. > > > > Seem like it might cause some random patterns in tiler :) > > Santosh, can youp please check it? > > > This is already fixed Tony. You have pulled that patch. > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg55258.html OK thanks. Yup, looks like it's queued up in l3 branch. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 4 Oct 2011 10:50:57 -0700 Subject: Please help with the OMAP static mapping mess In-Reply-To: References: <20111003205658.GJ6324@atomide.com> <20111003225908.GL6324@atomide.com> Message-ID: <20111004175057.GU6324@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Shilimkar, Santosh [111003 22:45]: > On Tue, Oct 4, 2011 at 4:29 AM, Tony Lindgren wrote: > > * Nicolas Pitre [111003 15:05]: > >> On Mon, 3 Oct 2011, Nicolas Pitre wrote: > >> > >> > On Mon, 3 Oct 2011, Tony Lindgren wrote: > >> > > >> > > * Nicolas Pitre [111003 11:26]: > >> > > > > >> > > > Furthermore... there is also a static mapping for physical address > >> > > > 0x4e000000 using virtual address 0xff100000 which is already reserved > >> > > > for other purposes i.e. the consistent DMA area. ?It is not immediately > >> > > > obvious where this comes from without being intimate with the OMAP code. > >> > > > Can this be fixed as well i.e. moved elsewhere please? > >> > > > >> > > This sounds like a bug somewhere. Which omap are you seeing this on? > >> > > >> > OMAP4430 on a Panda board. > >> > > >> > Here are the static mappings I'm seeing: > >> > > >> > phys = 0x44000000 virt = 0xf8000000 size = 0x100000 > >> > phys = 0x4a000000 virt = 0xfc000000 size = 0x400000 > >> > phys = 0x50000000 virt = 0xf9000000 size = 0x100000 > >> > phys = 0x4c000000 virt = 0xfd100000 size = 0x100000 > >> > phys = 0x4d000000 virt = 0xfe100000 size = 0x100000 > >> > phys = 0x4e000000 virt = 0xff100000 size = 0x100000 <--- > >> > phys = 0x48000000 virt = 0xfa000000 size = 0x400000 > >> > phys = 0x54000000 virt = 0xfe800000 size = 0x800000 > >> > >> It looks like this comes from OMAP44XX_DMM_VIRT. > >> > >> #define OMAP44XX_DMM_PHYS ? ? ? OMAP44XX_DMM_BASE > >> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? /* 0x4e000000 --> 0xfd300000 */ > >> #define OMAP44XX_DMM_VIRT ? ? ? (OMAP44XX_DMM_PHYS + OMAP4_L3_PER_IO_OFFSET) > >> #define OMAP44XX_DMM_SIZE ? ? ? SZ_1M > >> > >> The comment suggesting a mapping correspondance is obviously wrong. We have: > >> > >> #define OMAP44XX_DMM_BASE ? ? ? 0x4e000000 > >> #define OMAP4_L3_PER_IO_OFFSET ?0xb1100000 > >> > >> Hence 0x4e000000 + 0xb1100000 = 0xff100000. > > > > Seem like it might cause some random patterns in tiler :) > > Santosh, can youp please check it? > > > This is already fixed Tony. You have pulled that patch. > http://www.mail-archive.com/linux-omap at vger.kernel.org/msg55258.html OK thanks. Yup, looks like it's queued up in l3 branch. Tony