From: Carlos Maiolino <cmaiolino@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2_jadd: Fix error handlers
Date: Tue, 4 Oct 2011 16:26:01 -0300 [thread overview]
Message-ID: <20111004192601.GA4777@andromeda.usersys.redhat.com> (raw)
In-Reply-To: <1317755114.2777.82.camel@menhir>
> > @@ -212,10 +218,9 @@ create_new_inode(struct gfs2_sbd *sdp)
> > if (errno == EEXIST) {
> > error = unlink(name);
> > if (error)
> > - die( _("can't unlink %s: %s\n"),
> > - name, strerror(errno));
> > + perror("unlink");
> > } else
> > - die( _("can't create %s: %s\n"), name, strerror(errno));
> > + perror("create");
> > }
> In this case you should be passing the name that couldn't be created
> rather than the string "create" to perror. Otherwise the user won't know
> what the message refers to,
>
> Steve.
>
Gotcha, thanks Steve, I'll fix that on my next patch
--
--Carlos
next prev parent reply other threads:[~2011-10-04 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 17:44 [Cluster-devel] [PATCH] gfs2_jadd: Fix error handlers Carlos Maiolino
2011-10-04 19:05 ` Steven Whitehouse
2011-10-04 19:26 ` Carlos Maiolino [this message]
2011-10-04 18:16 Carlos Maiolino
2011-10-04 18:23 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111004192601.GA4777@andromeda.usersys.redhat.com \
--to=cmaiolino@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.