From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 06 Oct 2011 20:15:28 +0200 Subject: [U-Boot] RFC [PATCH 4/5 v5] dreamplug: initial board support. In-Reply-To: <1311715171-13128-4-git-send-email-u-boot@lakedaemon.net> References: <05ec95501d6c02ffeb1bc38d09fdca99142956a3.1307979826.git.u-boot@lakedaemon.net> <1311715171-13128-4-git-send-email-u-boot@lakedaemon.net> Message-ID: <20111006181528.0E9B8140874A@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jason Cooper, In message <1311715171-13128-4-git-send-email-u-boot@lakedaemon.net> you wrote: > Copied wholeheartedly from board/Marvell/guruplug and modified to add support > for SPI NOR flash. ... > + /* command to read PHY dev address */ > + if (miiphy_read(name, 0xEE, 0xEE, (u16 *) &devadr)) { > + printf("Err..%s could not read PHY dev address\n", > + __FUNCTION__); Checkpatch says: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Your own mileage may vary.