From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukasz Majewski <l.majewski@samsung.com>
Date: Fri, 07 Oct 2011 09:28:38 +0200
Subject: [U-Boot] [PATCH v2 3/5] usb:gadget: USB Mass Storage - files
 from Linux kernel
In-Reply-To: <20111006221019.8A563140874A@gemini.denx.de>
References: <1310567392-29082-1-git-send-email-l.majewski@samsung.com>
	<1310567392-29082-4-git-send-email-l.majewski@samsung.com>
	<20111006221019.8A563140874A@gemini.denx.de>
Message-ID: <20111007092838.02c6a42f@lmajewski.digital.local>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

> Dear Lukasz Majewski,
> 
> In message <1310567392-29082-4-git-send-email-l.majewski@samsung.com>
> you wrote:
> > Two files from Linux kernel source tree have been ported
> > to u-boot (Linux Kernel v2.6.34):
> > 
> > File file_storage.c
> > commit 2ecdc82ef0b03e67ce5ecee79d0d108177a704df
> > Author: Christoph Hellwig <hch@lst.de>
> > Date:   Tue Jan 26 17:27:20 2010 +0100
> > 
> >     kill unused invalidate_inode_pages helper
> > 
> > File storage_common.c
> > commit d26a6aa08b9f12b44fb1ee65625e7480d3d5bb81
> > Author: Michal Nazarewicz <m.nazarewicz@samsung.com>
> > Date:   Mon Nov 9 14:15:23 2009 +0100
> > 
> >     USB: g_mass_storage: code cleaned up and comments updated
> > 
> > In order to work with u-boot, changed were made.
> > 
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Minkyu Kang <mk7.kang@samsung.com>
> > Cc: Remy Bohmer <linux@bohmer.net>
> > ---
> >  drivers/usb/gadget/file_storage.c   | 3536
> > +++++++++++++++++++++++++++++++++++
> > drivers/usb/gadget/storage_common.c |  765 ++++++++ 2 files
> > changed, 4301 insertions(+), 0 deletions(-) create mode 100644
> > drivers/usb/gadget/file_storage.c create mode 100644
> > drivers/usb/gadget/storage_common.c
> 
> Checkpatch says:
> 
> total: 184 errors, 27 warnings, 4301 lines checked
> 
> Please clean up and resubmit.  Thanks.
> 

I'd like to ask about rules for porting - moving files from Linux.

As you can see this file is directly taken from Linux kernel. This code
has been accepted to kernel mainline.

So shall I:
1. Submit this patch again as is and
2. Post a separate patch to remove "warnings and errors" with my sign
off?

or:

1. Mangle this patch with my correction (186 errors is a lot) and then
resubmit it with my name included at sign-off?
Then it won't be anymore a file taken directly from Linux kernel.
Moreover we will duplicate code, since two different patches with two
identical functionality will emerge.

I'm a bit confused now...

-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center
Platform Group