From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Date: Fri, 7 Oct 2011 08:40:34 -0400 Subject: [U-Boot] RFC [PATCH 4/5 v5] dreamplug: initial board support. In-Reply-To: <20111006181528.0E9B8140874A@gemini.denx.de> References: <05ec95501d6c02ffeb1bc38d09fdca99142956a3.1307979826.git.u-boot@lakedaemon.net> <1311715171-13128-4-git-send-email-u-boot@lakedaemon.net> <20111006181528.0E9B8140874A@gemini.denx.de> Message-ID: <20111007124034.GH31288@titan.lakedaemon.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang, On Thu, Oct 06, 2011 at 08:15:28PM +0200, Wolfgang Denk wrote: > In message <1311715171-13128-4-git-send-email-u-boot@lakedaemon.net> you wrote: > > Copied wholeheartedly from board/Marvell/guruplug and modified to add support > > for SPI NOR flash. > ... > > + /* command to read PHY dev address */ > > + if (miiphy_read(name, 0xEE, 0xEE, (u16 *) &devadr)) { > > + printf("Err..%s could not read PHY dev address\n", > > + __FUNCTION__); > > Checkpatch says: > > WARNING: __func__ should be used instead of gcc specific __FUNCTION__ This is an old version of this patch. v8 is currently in Prafulla's u-boot-marvell git tree. It's fixed in there. thx, Jason.