All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Fasheh <mfasheh@suse.de>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [RFC][PATCH 1/2] vfs: allow /proc/pid/maps to return a custom device
Date: Fri, 7 Oct 2011 11:32:21 -0700	[thread overview]
Message-ID: <20111007183221.GA23779@wotan.suse.de> (raw)
In-Reply-To: <20110519201826.GN17822@wotan.suse.de>

Ressurecting an old thread, sorry. Here's the conversation thus far:

http://www.spinics.net/lists/linux-btrfs/msg10099.html

This is still hitting folks wishing to use btrfs on suse based systems.
Using getattr() (unconditionally I might add) is possible, but will affect
performance to a far greater degree than just allowing an optional deref of
whatever structure btrfs (and similar file systems) have to point to the
right block device. Is this really the way we would like to proceed? Chris,
maybe you can chime in here?
	--Mark

On Thu, May 19, 2011 at 01:18:26PM -0700, Mark Fasheh wrote:
> On Sat, May 14, 2011 at 08:06:04PM -0700, Eric W. Biederman wrote:
> > Mark Fasheh <mfasheh@suse.com> writes:
> > 
> > > This patch introduces a callback in the super_operations structure,
> > > 'get_maps_dev' which is then used by procfs to query which device to return
> > > for reporting in /proc/[PID]/maps.
> > 
> > No.
> > 
> > It may make sense to call the vfs stat method.  But introducing an extra
> > vfs operations for this seems like a maintenance nightmare.
> 
> Yeah I'm not thrilled with the extra method either. My concern with using
> ->getattr is whether it's too heavy since that implies potential disk /
> network i/o.
> 	--Mark

--
Mark Fasheh

      reply	other threads:[~2011-10-07 18:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13 23:18 [RFC][PATCH 0/2] btrfs/vfs: Return same device in stat(2) and /proc/pid/maps Mark Fasheh
2011-05-13 23:18 ` [RFC][PATCH 1/2] vfs: allow /proc/pid/maps to return a custom device Mark Fasheh
2011-05-15  3:06   ` Eric W. Biederman
2011-05-19 20:18     ` Mark Fasheh
2011-10-07 18:32       ` Mark Fasheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111007183221.GA23779@wotan.suse.de \
    --to=mfasheh@suse.de \
    --cc=chris.mason@oracle.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.