All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ted Ts'o" <tytso@mit.edu>
To: Nikitas Angelinas <nikitasangelinas@gmail.com>
Cc: adilger.kernel@dilger.ca, adilger@whamcloud.com,
	johann@whamcloud.com, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, nikitas_angelinas@xyratex.com,
	andrew_perepechko@xyratex.com
Subject: Re: [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd
Date: Sat, 8 Oct 2011 17:25:19 -0400	[thread overview]
Message-ID: <20111008212519.GO7948@thunk.org> (raw)
In-Reply-To: <1317339500-4341-3-git-send-email-nikitas_angelinas@xyratex.com>

On Fri, Sep 30, 2011 at 12:38:20AM +0100, Nikitas Angelinas wrote:
> Current logic would print an error message only once, and then
> 'failed_writes' would stay at 1. Rework the loop to increment
> 'failed_writes' and print the error message every s_mmp_update_interval
> * 60 seconds, as intended according to the comment.
> 
> Perhaps it would be better to reset 'failed_writes' to 0 on every
> successful write, such that new errors are noticed sooner, but maybe in
> the interest of efficiency it would be best not to add an operation on
> every kmmpd thread run?
> 
> Signed-off-by: Nikitas Angelinas <nikitas_angelinas@xyratex.com>
> Signed-off-by: Andrew Perepechko <andrew_perepechko@xyratex.com>
> Acked-by: Andreas Dilger <adilger@dilger.ca>

Thanks, applied.

						- Ted

      reply	other threads:[~2011-10-08 21:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23  0:23 [PATCH 0/2] ext4: Some MMP fixes Nikitas Angelinas
2011-09-23  0:23 ` [PATCH 1/2] ext4: MMP: kmmpd should use nodename from init_uts_ns.name, not sysname Nikitas Angelinas
2011-09-23  8:24   ` Andrew Perepechko
2011-09-23 11:30     ` Andrew Perepechko
2011-09-23 18:51   ` Andreas Dilger
2011-09-23  0:23 ` [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd Nikitas Angelinas
2011-09-23 18:51   ` Andreas Dilger
2011-09-29 23:38 ` Nikitas Angelinas
2011-09-29 23:38   ` (unknown), Nikitas Angelinas
2011-09-29 23:38   ` [PATCH 1/2] ext4: MMP: kmmpd should use nodename from init_uts_ns.name, not sysname Nikitas Angelinas
2011-10-08 21:22     ` Ted Ts'o
2011-09-29 23:38   ` [PATCH 2/2] ext4: MMP: fix error message rate-limiting logic in kmmpd Nikitas Angelinas
2011-10-08 21:25     ` Ted Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111008212519.GO7948@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=adilger@whamcloud.com \
    --cc=andrew_perepechko@xyratex.com \
    --cc=johann@whamcloud.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikitas_angelinas@xyratex.com \
    --cc=nikitasangelinas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.