From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 09 Oct 2011 21:43:36 +0200 Subject: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation In-Reply-To: <20111007093950.17d94287@lmajewski.digital.local> References: <1310567392-29082-1-git-send-email-l.majewski@samsung.com> <1310567392-29082-2-git-send-email-l.majewski@samsung.com> <20111006221048.39BEC140874A@gemini.denx.de> <20111007093950.17d94287@lmajewski.digital.local> Message-ID: <20111009194336.C84971408775@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lukasz Majewski, In message <20111007093950.17d94287@lmajewski.digital.local> you wrote: > > Most warnings are related to lines over 80 characters. > This code is a debug code. As fair as I remember debug print code shall > not be break in Linux kernel for easier debugging. Can you please point me to the respective entry in the CodingStyle file? > I don't know what is the policy in u-boot. I haven't seen any guideline > about breaking debug code when it is larger than 80 characters (so I > stick to kernel policy). We make no distinction between different "types" of code. > Other warnings are related to kernel API (like the min() macro usage) > which is different in u-boot. So it needs to be fixed? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A supercomputer is a machine that runs an endless loop in 2 seconds.