All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] OMAP3: mvblx: Initial support for mvBlueLYNX-X
Date: Sun, 09 Oct 2011 21:59:50 +0200	[thread overview]
Message-ID: <20111009195950.731511408775@gemini.denx.de> (raw)
In-Reply-To: <4E8EC11B.8040207@matrix-vision.de>

Dear Michael Jones,

In message <4E8EC11B.8040207@matrix-vision.de> you wrote:
> 
> But while we're on the topic- Most of those old warnings were because my 
> board/matrix_vision/mvblx/mvblx.h was based on board/ti/beagle/beagle.h, 
> which would've itself had lots of checkpatch warnings from long lines. 
> Sandeep advised me that this was a poor argument for submitting a patch 
> with warnings, so I submitted v5.  Now I've researched this again and 
> found the patch which introduced the warnings for beagle.h and the 
> discussion [2] around it.  If it was decided back then to indent the 
> lines with tabs although it caused checkpatch warnings, isn't it 
> reasonable for mvblx.h to be formatted in the same way?  I don't care 
> how it's formatted, but I find the inconsistency ugly.

There are a few cases where longer lines actually provide better
readbility than wrapping the code - these are things like tables of
MUX initializations, and the like.

But "normal" code or header files has a strict 80 char line length
limit.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Star Trek Lives!

  reply	other threads:[~2011-10-09 19:59 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-15  9:09 [U-Boot] [PATCH 0/7] OMAP3: Add support for mvBlueLYNX-X Michael Jones
2011-07-15  9:09 ` [U-Boot] [PATCH 1/7] fpga: add #define for Altera Cyclone EP3C5 Michael Jones
2011-07-28 14:46   ` Wolfgang Denk
2011-07-15  9:09 ` [U-Boot] [PATCH 2/7] fpga: support FPP Cyclone configuration Michael Jones
2011-07-28 14:47   ` Wolfgang Denk
2011-07-15  9:09 ` [U-Boot] [PATCH 3/7] ARMV7: OMAP3: Add 37xx ESx revision numbers Michael Jones
2011-07-18 14:36   ` [U-Boot] [PATCH v2 " Michael Jones
2011-07-15  9:09 ` [U-Boot] [PATCH 4/7] mmc: rescan fails on empty slot Michael Jones
2011-07-18 14:40   ` [U-Boot] [PATCH v2 " Michael Jones
2011-08-17  2:15     ` Andy Fleming
2011-08-17  2:30       ` Andy Fleming
2011-08-17  7:46         ` Michael Jones
2011-07-19  2:06   ` [U-Boot] [PATCH " Jaehoon Chung
2011-07-20  8:51     ` Michael Jones
2011-07-20  9:52       ` Jaehoon Chung
2011-07-15  9:09 ` [U-Boot] [PATCH 5/7] mv_common.c: don't compile reset_environment if ENV_IS_NOWHERE Michael Jones
2011-07-18 14:45   ` [U-Boot] [PATCH v2 " Michael Jones
2011-07-28 14:49     ` Wolfgang Denk
2011-07-18 17:39   ` [U-Boot] [PATCH " Mike Frysinger
2011-07-15  9:09 ` [U-Boot] [PATCH 6/7] ARMV7: OMAP: I2C driver: Write more than 1 byte at a time in i2c_write Michael Jones
2011-07-18 14:58   ` [U-Boot] [PATCH v2 " Michael Jones
2011-07-27  6:07     ` Heiko Schocher
2011-07-27  7:42       ` Michael Jones
2011-07-27  7:53         ` Heiko Schocher
2011-07-27 12:41           ` [U-Boot] [PATCH v3] " Michael Jones
2011-07-27 12:41             ` [U-Boot] [PATCH] ARMV7: OMAP: I2C driver: cosmetic: make checkpatch-compatible Michael Jones
2011-08-01  9:12             ` [U-Boot] [PATCH v3] ARMV7: OMAP: I2C driver: Write more than 1 byte at a time in i2c_write Heiko Schocher
2011-08-01 10:14               ` [U-Boot] [PATCH v4] " Michael Jones
2011-08-02  6:37                 ` Heiko Schocher
2011-09-04 17:59                   ` Paulraj, Sandeep
2011-09-05  5:34                     ` Heiko Schocher
2011-07-27 21:00         ` [U-Boot] [PATCH v2 6/7] " Wolfgang Denk
2011-07-15  9:09 ` [U-Boot] [PATCH 7/7] OMAP3: mvblx: Initial support for mvBlueLYNX-X Michael Jones
2011-07-18 15:00   ` [U-Boot] [PATCH v2 " Michael Jones
2011-07-27  9:57     ` Igor Grinberg
2011-08-04 13:46     ` [U-Boot] [PATCH v3] " Michael Jones
2011-10-06 22:06       ` Wolfgang Denk
2011-08-17  8:55 ` [U-Boot] [PATCH v4] " Michael Jones
2011-10-06 21:51   ` Wolfgang Denk
2011-10-07  9:06     ` Michael Jones
2011-10-09 19:59       ` Wolfgang Denk [this message]
2011-10-05 15:08 ` [U-Boot] [PATCH v5] " Michael Jones
2011-10-10 15:08   ` [U-Boot] [PATCH v6] " Michael Jones
2011-10-18 17:31   ` [U-Boot] [PATCH v5] " Tom Rini
2011-10-19  8:16     ` Michael Jones
2011-10-20 11:37     ` [U-Boot] [PATCH] mv_common.c: get rid of 'defined but not used' warning Michael Jones
2011-10-20 11:48       ` Andre Schwarz
2011-12-03 12:32       ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111009195950.731511408775@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.