All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Venki Pallipadi <venki@google.com>, Ingo Molnar <mingo@elte.hu>,
	Prarit Bhargava <prarit@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@kernel.org" <stable@kernel.org>
Subject: Re: [patch v2 1/2] sched: Use resched IPI to kick off the nohz idle balance
Date: Mon, 10 Oct 2011 09:52:20 -0400	[thread overview]
Message-ID: <20111010135220.GC21169@redhat.com> (raw)
In-Reply-To: <1318032586.11592.206.camel@sbsiddha-desk.sc.intel.com>

On Fri, Oct 07, 2011 at 05:09:46PM -0700, Suresh Siddha wrote:
> On Thu, 2011-10-06 at 10:27 -0700, Vivek Goyal wrote:
> > On Mon, Oct 03, 2011 at 03:09:00PM -0700, Suresh Siddha wrote:
> > [..]
> > > 
> > >    [ This issue is present from 2.6.35+ kernels, but marking it -stable
> > >      only from v3.0+ as the proposed fix depends on the scheduler_ipi()
> > >      that is introduced recently. ]
> > > 
> > 
> > Hi Suresh,
> > 
> > Are you planning to fix this issue for older kernels too? I am wondering
> > how to go about fixing it there.
> > 
> 
> Vivek, Initially when Prarit brought this issue to me, I gave an ugly
> quick fix (Appended) for a quick try. But I would recommend we back port
> the couple of mainline patches that introduced scheduler_ipi() code
> along with these two patches. Thoughts?

I agree that backporting scheduler_ipi() patches makes more sense.
Browsing through the code looks like we need just one commit which
introduced scheduler_ipi().

commit 184748cc50b2dceb8287f9fb657eda48ff8fcfe7
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date:   Tue Apr 5 17:23:39 2011 +0200

    sched: Provide scheduler_ipi() callback in response to smp_send_reschedule()

I did partial backport of above to come up with a fix for rhel6 and put
your first patch on top of it. 

Once your current patches get merged, I can backport above and two of
your patches for older kernel is there is interest.

Thanks
Vivek

  reply	other threads:[~2011-10-10 13:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-03 22:09 [patch v2 1/2] sched: Use resched IPI to kick off the nohz idle balance Suresh Siddha
2011-10-03 22:09 ` [patch v2 2/2] sched: Request for idle balance during nohz idle load balance Suresh Siddha
2011-10-04  9:05 ` [patch v2 1/2] sched: Use resched IPI to kick off the nohz idle balance Peter Zijlstra
2011-10-04 18:03   ` Suresh Siddha
2011-10-06 17:27 ` Vivek Goyal
2011-10-08  0:09   ` Suresh Siddha
2011-10-10 13:52     ` Vivek Goyal [this message]
2011-10-10 14:06       ` Peter Zijlstra
2011-10-10 15:25         ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111010135220.GC21169@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=prarit@redhat.com \
    --cc=stable@kernel.org \
    --cc=suresh.b.siddha@intel.com \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=venki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.