From: Malahal Naineni <malahal@us.ibm.com>
To: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs: only do COMMIT for range written with direct I/O
Date: Wed, 30 Nov 2011 08:56:57 -0600 [thread overview]
Message-ID: <20111130145657.GA7883@us.ibm.com> (raw)
In-Reply-To: <1322662074-3843-1-git-send-email-jlayton@redhat.com>
Jeff Layton [jlayton@redhat.com] wrote:
> When given a range to write with unstable writes, the current code
> always does a COMMIT of the entire file afterward. This is potentially
> expensive on some servers and unnecessary. Instead, just do a COMMIT for
> the offset and count that was written.
>
> Khoa, who reported this bug, stated that this made a big difference in
> performance in their environment, which I believe involves GPFS on the
> server. He didn't pass along any hard numbers so I can't quantify the
> gain, but it stands to reason that clustered filesystems might suffer
> more contention issues when issuing a commit over the whole file.
>
> Reported-by: Khoa Huynh <khoa@us.ibm.com>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> fs/nfs/direct.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
> index 1940f1a..33f2be7 100644
> --- a/fs/nfs/direct.c
> +++ b/fs/nfs/direct.c
> @@ -77,6 +77,7 @@ struct nfs_direct_req {
> /* completion state */
> atomic_t io_count; /* i/os we're waiting for */
> spinlock_t lock; /* protect completion state */
> + loff_t pos; /* offset into file */
Why not call it "offset"? Should we set this to zero in
nfs_direct_req_alloc (just like count is set to zero there)?
Thanks, Malahal.
next prev parent reply other threads:[~2011-11-30 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 14:07 [PATCH] nfs: only do COMMIT for range written with direct I/O Jeff Layton
2011-11-30 14:56 ` Malahal Naineni [this message]
2011-11-30 19:25 ` Jeff Layton
2011-12-05 17:11 ` Jeff Layton
2011-12-05 18:06 ` Myklebust, Trond
2011-12-13 15:02 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130145657.GA7883@us.ibm.com \
--to=malahal@us.ibm.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.