All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/intel_mid: Fix the Kconfig for MID selection
@ 2011-12-05 23:14 Alan Cox
  2011-12-06  6:29 ` [tip:x86/platform] " tip-bot for Alan Cox
  2011-12-06 10:37 ` [tip:x86/urgent] " tip-bot for Alan Cox
  0 siblings, 2 replies; 3+ messages in thread
From: Alan Cox @ 2011-12-05 23:14 UTC (permalink / raw)
  To: mingo, linux-next

From: Alan Cox <alan@linux.intel.com>

We could build all the bits to make generic MID work if you picked
MID platform alone but that's really silly. Instead use select and
two variables.

This looks a bit daft right now but once we add a Medfield selection
it'll start to look a good deal more sensible.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 arch/x86/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 4ee940c..b884f4c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -395,7 +395,7 @@ config X86_INTEL_CE
 	  This option compiles in support for the CE4100 SOC for settop
 	  boxes and media devices.
 
-config X86_INTEL_MID
+config X86_WANT_INTEL_MID
 	bool "Intel MID platform support"
 	depends on X86_32
 	depends on X86_EXTENDED_PLATFORM
@@ -404,7 +404,7 @@ config X86_INTEL_MID
 	  systems which do not have the PCI legacy interfaces (Moorestown,
 	  Medfield). If you are building for a PC class system say N here.
 
-if X86_INTEL_MID
+if X86_WANT_INTEL_MID
 
 config X86_MRST
        bool "Moorestown MID platform"
@@ -416,6 +416,7 @@ config X86_MRST
 	select SPI
 	select INTEL_SCU_IPC
 	select X86_PLATFORM_DEVICES
+	select X86_INTEL_MID
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:x86/platform] x86/intel_mid: Fix the Kconfig for MID selection
  2011-12-05 23:14 [PATCH] x86/intel_mid: Fix the Kconfig for MID selection Alan Cox
@ 2011-12-06  6:29 ` tip-bot for Alan Cox
  2011-12-06 10:37 ` [tip:x86/urgent] " tip-bot for Alan Cox
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Alan Cox @ 2011-12-06  6:29 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, alan, hpa, mingo, tglx, mingo

Commit-ID:  b4b547d311e01f276f267beeef8ac1cbb311f058
Gitweb:     http://git.kernel.org/tip/b4b547d311e01f276f267beeef8ac1cbb311f058
Author:     Alan Cox <alan@linux.intel.com>
AuthorDate: Mon, 5 Dec 2011 23:14:39 +0000
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 6 Dec 2011 06:57:29 +0100

x86/intel_mid: Fix the Kconfig for MID selection

We could build all the bits to make generic MID work if you
picked MID platform alone but that's really silly. Instead use
select and two variables.

This looks a bit daft right now but once we add a Medfield
selection it'll start to look a good deal more sensible.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/20111205231433.28811.51297.stgit@bob.linux.org.uk
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index faf39a0..417883b 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -390,7 +390,7 @@ config X86_INTEL_CE
 	  This option compiles in support for the CE4100 SOC for settop
 	  boxes and media devices.
 
-config X86_INTEL_MID
+config X86_WANT_INTEL_MID
 	bool "Intel MID platform support"
 	depends on X86_32
 	depends on X86_EXTENDED_PLATFORM
@@ -399,7 +399,7 @@ config X86_INTEL_MID
 	  systems which do not have the PCI legacy interfaces (Moorestown,
 	  Medfield). If you are building for a PC class system say N here.
 
-if X86_INTEL_MID
+if X86_WANT_INTEL_MID
 
 config X86_MRST
        bool "Moorestown MID platform"
@@ -411,6 +411,7 @@ config X86_MRST
 	select SPI
 	select INTEL_SCU_IPC
 	select X86_PLATFORM_DEVICES
+	select X86_INTEL_MID
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:x86/urgent] x86/intel_mid: Fix the Kconfig for MID selection
  2011-12-05 23:14 [PATCH] x86/intel_mid: Fix the Kconfig for MID selection Alan Cox
  2011-12-06  6:29 ` [tip:x86/platform] " tip-bot for Alan Cox
@ 2011-12-06 10:37 ` tip-bot for Alan Cox
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Alan Cox @ 2011-12-06 10:37 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, alan, hpa, mingo, tglx, sgruszka, mingo

Commit-ID:  dd13752537d36cc6c145cb040f71ce7acda31e6e
Gitweb:     http://git.kernel.org/tip/dd13752537d36cc6c145cb040f71ce7acda31e6e
Author:     Alan Cox <alan@linux.intel.com>
AuthorDate: Mon, 5 Dec 2011 23:14:39 +0000
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 6 Dec 2011 11:28:36 +0100

x86/intel_mid: Fix the Kconfig for MID selection

We currently fail to build on CONFIG_X86_INTEL_MID=y and
CONFIG_X86_MRST unset.

We could build all the bits to make generic MID work if you
picked MID platform alone but that's really silly. Instead use
select and two variables.

This looks a bit daft right now but once we add a Medfield
selection it'll start to look a good deal more sensible.

Reported-by: Ingo Molnar <mingo@elte.hu>
Reported-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Link: http://lkml.kernel.org/r/20111205231433.28811.51297.stgit@bob.linux.org.uk
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index cb9a104..5553f9f 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -390,7 +390,7 @@ config X86_INTEL_CE
 	  This option compiles in support for the CE4100 SOC for settop
 	  boxes and media devices.
 
-config X86_INTEL_MID
+config X86_WANT_INTEL_MID
 	bool "Intel MID platform support"
 	depends on X86_32
 	depends on X86_EXTENDED_PLATFORM
@@ -399,7 +399,7 @@ config X86_INTEL_MID
 	  systems which do not have the PCI legacy interfaces (Moorestown,
 	  Medfield). If you are building for a PC class system say N here.
 
-if X86_INTEL_MID
+if X86_WANT_INTEL_MID
 
 config X86_MRST
        bool "Moorestown MID platform"
@@ -411,6 +411,7 @@ config X86_MRST
 	select SPI
 	select INTEL_SCU_IPC
 	select X86_PLATFORM_DEVICES
+	select X86_INTEL_MID
 	---help---
 	  Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
 	  Internet Device(MID) platform. Moorestown consists of two chips:

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-12-06 10:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-05 23:14 [PATCH] x86/intel_mid: Fix the Kconfig for MID selection Alan Cox
2011-12-06  6:29 ` [tip:x86/platform] " tip-bot for Alan Cox
2011-12-06 10:37 ` [tip:x86/urgent] " tip-bot for Alan Cox

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.