From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 06 Dec 2011 11:41:59 +0100 Subject: [U-Boot] [PATCH] pxe: get ethaddr from the current device instead of env In-Reply-To: <1323129873-8786-1-git-send-email-robherring2@gmail.com> References: <1323129873-8786-1-git-send-email-robherring2@gmail.com> Message-ID: <20111206104159.5E9EA1F9E48@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Rob Herring, In message <1323129873-8786-1-git-send-email-robherring2@gmail.com> you wrote: > > The env variable "ethaddr" may not be set, so get the address from the > eth_device struct instead. This also enables pxe for secondary ethernet > devices. This is not correct. The "ethaddr" environment variable shall always take precedence. Feel free to _additionally_ test other places that store this information. If the "ethaddr" environment variable is not set, then this alternative value can be used as default. In this case a warning should be printed. If both settings exist and differ, the "ethaddr" environment variable shall be used, and a warning be printed, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The shortest unit of time in the multiverse is the News York Second, defined as the period of time between the traffic lights turning green and the cab behind you honking. - Terry Pratchett, _Lords and Ladies_