From: Ben Hutchings <ben@decadent.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags on error
Date: Tue, 6 Dec 2011 21:13:42 +0000 [thread overview]
Message-ID: <20111206211342.GI3366@decadent.org.uk> (raw)
In-Reply-To: <20111206191458.GA25568@elte.hu>
On Tue, Dec 06, 2011 at 08:14:58PM +0100, Ingo Molnar wrote:
>
> Anyway, SOB flaming aside, i think there's now consensus that we
> don't want to disable lockdep for TAINT_OOT modules.
OK, glad we could work this out.
> Mind (re-)sending a delta patch against tip:master that excludes
> that taint flag in addition to the already excluded
> TAINT_FIRMWARE case? That should close this rather verbose
> chapter of taint flag handling changes for good ;-)
I originally assumed that lock debugging was being disabled on a
tainted kernel in order to save kernel developers from having to
handle false lockdep errors that are due to external bugs. The
intent of my proposed change was to achieve this same effect by
showing taint flags instead. Although the immediate motivation
for this was the new TAINT_OOT_MODULE, I don't see that it is
important for any taint flag to have this disabling effect now.
If you want to ensure that lock debugging is not available to
proprietary modules, I don't have a problem with that, although there
is no legal or practical way for us to stop proprietary module
developers evading this check and doing lock debugging in the privacy
of their offices.
So what I would like to do is either:
1. No longer disable lock debugging due to any taint
or
2. Disable lock debugging only when TAINT_PROPRIETARY_MODULE is set
Ben.
--
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
- Albert Camus
next prev parent reply other threads:[~2011-12-06 21:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 3:36 [PATCH 1/2] lockdep,rtmutex,bug: Show taint flags on error Ben Hutchings
2011-10-31 1:59 ` Rusty Russell
2011-11-16 21:52 ` Ben Hutchings
2011-11-16 22:24 ` Dave Jones
2011-11-17 8:48 ` Peter Zijlstra
2011-11-17 15:18 ` Ben Hutchings
2011-12-06 9:38 ` [tip:core/locking] lockdep, rtmutex, bug: " tip-bot for Ben Hutchings
2011-12-06 15:34 ` Ben Hutchings
2011-12-06 17:48 ` Peter Zijlstra
2011-12-06 17:55 ` Alan Cox
2011-12-06 17:56 ` Peter Zijlstra
2011-12-06 17:59 ` Ingo Molnar
2011-12-06 18:17 ` Ben Hutchings
2011-12-06 18:28 ` Ingo Molnar
2011-12-06 19:14 ` Ingo Molnar
2011-12-06 21:13 ` Ben Hutchings [this message]
2011-12-07 7:49 ` Ingo Molnar
2011-12-06 18:04 ` Ingo Molnar
2011-12-06 17:54 ` Ingo Molnar
2011-12-06 18:14 ` Nick Bowler
2011-12-06 18:20 ` Ingo Molnar
2011-12-06 18:21 ` Alan Cox
2011-12-06 18:34 ` Ingo Molnar
2011-12-06 18:23 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206211342.GI3366@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.