From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sat, 17 Dec 2011 21:05:32 +0100 Subject: [U-Boot] [PATCH] common/cmd_nvedit.c: Fix size calculation in do_env_import() In-Reply-To: <1324114390-27290-1-git-send-email-hkronsto@frequentis.com> References: <1324114390-27290-1-git-send-email-hkronsto@frequentis.com> Message-ID: <20111217200532.F28D71ECC61@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Horst Kronstorfer, In message <1324114390-27290-1-git-send-email-hkronsto@frequentis.com> you wrote: > do_env_import() missed the final '\0' terminator when calculating the > size of an environment data block. This led to an erroneous 'bad CRC, > import failed' message for a checksum protected environment (-c.) Can you please describe a test case that shows this bug? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de God made the integers; all else is the work of Man. - Kronecker