All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Paul Anderson <pha@umich.edu>,
	Sean Thomas Caron <scaron@umich.edu>,
	xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: log all dirty inodes in xfs_fs_sync_fs
Date: Sun, 18 Dec 2011 17:32:39 -0500	[thread overview]
Message-ID: <20111218223239.GA10435@infradead.org> (raw)
In-Reply-To: <20111218221707.GH23662@dastard>

On Mon, Dec 19, 2011 at 09:17:07AM +1100, Dave Chinner wrote:
> This will do a transaction on the inode, clean or dirty. That's an
> awful lot of overhead for the few inodes (out of perhaps millions in
> memory) that actually need it. with the ->dirty_inode callback from
> the VFS, we know the only inodes that need logging are those with
> i_update_core set....

Ooops, I messed that up when forwarding the RFC patch I sent to
Paul & Sean, and that I had been testing with most of the time.  The
original one moved the i_update_core check into xfs_log_inode and that
is how it should be done.  I'll resend it.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-12-18 22:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20111218154936.GA17626@infradead.org>
2011-12-18 15:49 ` [PATCH 1/1] xfs: log the inode in ->write_inode calls for kupdate Christoph Hellwig
2011-12-20 21:19   ` Dave Chinner
2011-12-23 15:55   ` Mark Tinguely
2011-12-23 17:58   ` Ben Myers
2011-12-28 21:35   ` Hans-Peter Jansen
2011-12-28 21:39     ` Christoph Hellwig
2011-12-18 15:50 ` [PATCH 2/2] xfs: log all dirty inodes in xfs_fs_sync_fs Christoph Hellwig
2011-12-18 20:03   ` Sean Thomas Caron
2011-12-18 20:09     ` Christoph Hellwig
2011-12-18 22:17   ` Dave Chinner
2011-12-18 22:32     ` Christoph Hellwig [this message]
2011-12-20 20:08   ` [PATCH 2/2 v2] " Christoph Hellwig
2011-12-20 21:21     ` Dave Chinner
2011-12-23 15:55     ` Mark Tinguely
2011-12-23 21:47     ` Ben Myers
2011-12-26 12:13       ` Dave Chinner
2011-12-29 15:42         ` Ben Myers
2011-12-29 21:44           ` Dave Chinner
2012-01-03 15:48             ` Mark Tinguely
2011-12-21 17:40 ` sync fixes Christoph Hellwig
     [not found] <20120104093015.056917499@bombadil.infradead.org>
2012-01-04  9:30 ` [PATCH 2/2] xfs: log all dirty inodes in xfs_fs_sync_fs Christoph Hellwig
     [not found] <20120104144834.869111452@bombadil.infradead.org>
2012-01-04 14:48 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111218223239.GA10435@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=pha@umich.edu \
    --cc=scaron@umich.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.