All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: autotest@test.kernel.org
Cc: lmr@redhat.com, wquan@redhat.com, kvm@vger.kernel.org,
	jasowang@redhat.com, kristof.katus@intra2net.com,
	qzhou@redhat.com
Subject: [PATCH] virt-test: support static ip address in framework
Date: Mon, 19 Dec 2011 21:11:32 +0800	[thread overview]
Message-ID: <20111219131132.7235.31811.stgit@dhcp-8-167.nay.redhat.com> (raw)

Sometime, we need to test with guest(s) which have static ip
address(es).
eg. No real/emulated DHCP server in test environment.
eg. Test with old image we don't want to change the net config.
eg. Test when DHCP exists problem.

This is an example of using static ip address:
1. edit ifcfg-eth0 of guest to assign static IP
   (192.168.100.110). You can also do this by install
   post-script/serial.
2. add and setup bridge in host
   # brctl addbr vbr
   # ifconfig vbr 192.168.100.1
3. add script for setup tap device
   /etc/qemu-ifup-vbr
   | #!/bin/sh
   | switch=vbr
   | /sbin/ifconfig $1 0.0.0.0 up
   | /usr/sbin/brctl addif ${switch} $1
   | /usr/sbin/brctl setfd ${switch} 0
   | /usr/sbin/brctl stp ${switch} off
4. assign parameters in config file and execute test as usual
   test.cfg:
   | ip_nic1 = 192.168.100.110
   | mac_nic1 = 11:22:33:44:55:67
   | bridge = vbr

Signed-off-by: Amos Kong <akong@redhat.com>
---
 client/tests/kvm/base.cfg.sample |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/client/tests/kvm/base.cfg.sample b/client/tests/kvm/base.cfg.sample
index 411decf..c86ec1f 100644
--- a/client/tests/kvm/base.cfg.sample
+++ b/client/tests/kvm/base.cfg.sample
@@ -17,6 +17,9 @@ nics = nic1
 # Connect NIC devices to host bridge device
 bridge = virbr0
 
+# Tell framework of nic1's static ip address
+ip_nic1 = 192.168.100.110
+
 # List of block device object names (whitespace seperated)
 images = image1
 # List of optical device object names
diff --git a/client/virt/kvm_vm.py b/client/virt/kvm_vm.py
index fa258c3..1fb177f 100644
--- a/client/virt/kvm_vm.py
+++ b/client/virt/kvm_vm.py
@@ -821,7 +821,12 @@ class VM(virt_vm.BaseVM):
                 if mac:
                     virt_utils.set_mac_address(self.instance, vlan, mac)
                 else:
-                    virt_utils.generate_mac_address(self.instance, vlan)
+                    mac = virt_utils.generate_mac_address(self.instance, vlan)
+
+                if nic_params.get("ip"):
+                    self.address_cache[mac] = nic_params.get("ip")
+                    logging.debug("(address cache) Adding static cache entry: "
+                                  "%s ---> %s" % (mac, nic_params.get("ip")))
 
             # Assign a PCI assignable device
             self.pci_assignable = None


             reply	other threads:[~2011-12-19 13:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 13:11 Amos Kong [this message]
2011-12-20  3:14 ` [PATCH] virt-test: support static ip address in framework Qingtang Zhou
2011-12-20  3:37   ` Amos Kong
2011-12-20 19:03 ` Lucas Meneghel Rodrigues
2011-12-21  5:56   ` Amos Kong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219131132.7235.31811.stgit@dhcp-8-167.nay.redhat.com \
    --to=akong@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=jasowang@redhat.com \
    --cc=kristof.katus@intra2net.com \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    --cc=qzhou@redhat.com \
    --cc=wquan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.