All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-usb <linux-usb@vger.kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	heikki.krogerus@linux.intel.com
Subject: Re: linux-next: Tree for Dec 16 (usb/gadget/langwell)
Date: Mon, 19 Dec 2011 15:26:25 +0200	[thread overview]
Message-ID: <20111219132623.GD3146@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20111216223505.GA14030@legolas.emea.dhcp.ti.com>

[-- Attachment #1: Type: text/plain, Size: 3542 bytes --]

Hi,

On Sat, Dec 17, 2011 at 12:35:06AM +0200, Felipe Balbi wrote:
> On Fri, Dec 16, 2011 at 11:15:44AM -0800, Randy Dunlap wrote:
> > On 12/15/2011 10:00 PM, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > Changes since 20111215:
> > 
> > 
> > (not new today; I saw this last week but apparently did not
> > get around to reporting it)
> > 
> > 
> > drivers/usb/gadget/langwell_udc.c: In function 'handle_setup_packet':
> > drivers/usb/gadget/langwell_udc.c:2321:19: error: 'struct langwell_otg' has no member named 'otg'
> > drivers/usb/gadget/langwell_udc.c:2322:15: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c: In function 'handle_usb_reset':
> > drivers/usb/gadget/langwell_udc.c:2757:16: error: 'struct langwell_otg' has no member named 'otg'
> > drivers/usb/gadget/langwell_udc.c:2758:12: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c: In function 'handle_bus_suspend':
> > drivers/usb/gadget/langwell_udc.c:2774:15: error: 'struct langwell_otg' has no member named 'otg'
> > drivers/usb/gadget/langwell_udc.c:2775:16: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c:2776:13: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c:2779:5: error: implicit declaration of function 'langwell_update_transceiver'
> > drivers/usb/gadget/langwell_udc.c:2783:12: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c:2785:17: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c:2786:13: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c: In function 'handle_bus_resume':
> > drivers/usb/gadget/langwell_udc.c:2827:15: error: 'struct langwell_otg' has no member named 'otg'
> > drivers/usb/gadget/langwell_udc.c:2828:12: error: 'struct langwell_otg' has no member named 'hsm'
> > drivers/usb/gadget/langwell_udc.c: In function 'langwell_udc_probe':
> > drivers/usb/gadget/langwell_udc.c:3119:2: error: implicit declaration of function 'otg_to_langwell'
> > drivers/usb/gadget/langwell_udc.c:3119:12: warning: assignment makes pointer from integer without a cast
> > drivers/usb/gadget/langwell_udc.c:3120:18: error: 'struct langwell_otg' has no member named 'regs'
> > drivers/usb/gadget/langwell_udc.c: In function 'init':
> > drivers/usb/gadget/langwell_udc.c:3529:2: error: implicit declaration of function 'langwell_register_peripheral'
> > drivers/usb/gadget/langwell_udc.c: In function 'cleanup':
> > drivers/usb/gadget/langwell_udc.c:3540:2: error: implicit declaration of function 'langwell_unregister_peripheral'
> > drivers/usb/gadget/langwell_udc.c:3540:2: warning: 'return' with a value, in function returning void
> 
> aparently this has never been compiled with CONFIG_USB_LANGWELL_OTG
> before.
> 
> Xiaochen, please fix that ASAP. Now that I look at it, that driver
> should have been on staging. It's pretty messed up. Isn't it one of
> those devices which is based on ChipIdea's core ? I wonder when that
> consolidation work will get done.
> 
> I expect to see this fixed still on 3.2 series. Also needs a backport to
> fix older stable kernels. v2.6.31 is the first kernel with that driver
> available.
> 
> Thanks for the report Randy

Xiaochen Shen <xiaochen.shen@intel.com> doesn't exist anymore. Maybe
Alex and/or Heikki can take a look at it

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2011-12-19 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16  6:00 linux-next: Tree for Dec 16 Stephen Rothwell
2011-12-16 19:15 ` linux-next: Tree for Dec 16 (usb/gadget/langwell) Randy Dunlap
2011-12-16 22:35   ` Felipe Balbi
2011-12-19 13:26     ` Felipe Balbi [this message]
2011-12-16 19:42 ` linux-next: Tree for Dec 16 (intel_scu & abp_timer) Randy Dunlap
2011-12-16 18:50   ` Alan Cox
2011-12-16 22:25 ` linux-next: Tree for Dec 16 (leds/tca6507) Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219132623.GD3146@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.