From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:46814 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813Ab1LUBGV (ORCPT ); Tue, 20 Dec 2011 20:06:21 -0500 From: Laurent Pinchart To: Martin Hostettler Subject: Re: [PATCH v4] v4l: Add driver for Micron MT9M032 camera sensor Date: Wed, 21 Dec 2011 02:06:20 +0100 Cc: Hans Verkuil , linux-media@vger.kernel.org References: <1324116655-15895-1-git-send-email-martin@neutronstar.dyndns.org> In-Reply-To: <1324116655-15895-1-git-send-email-martin@neutronstar.dyndns.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201112210206.20567.laurent.pinchart@ideasonboard.com> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Martin, Thanks for the patch. On Saturday 17 December 2011 11:10:55 Martin Hostettler wrote: > The MT9M032 is a parallel 1.6MP sensor from Micron controlled through I2C. > > The driver creates a V4L2 subdevice. It currently supports cropping, gain, > exposure and v/h flipping controls in monochrome mode with an > external pixel clock. There are still several small issues with this driver. Things like not using the module_i2c_driver() macro, some indentation, magic values in registers (I'm trying to get more documentation), PLL setup (although that can be fixed later, it's not a requirement for the driver to be mainlined), ... Would you be fine if I took the patch in my tree, fixed the remaining issues and pushed it to mainline for v3.4 (the time frame is too short for v3.3) ? Authorship will of course be preserved. The alternative would be to go through review/modification cycles, and I don't want to waste too much of your time :-) -- Best regards, Laurent Pinchart