All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: martin@neutronstar.dyndns.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Subject: Re: [PATCH v4] v4l: Add driver for Micron MT9M032 camera sensor
Date: Wed, 21 Dec 2011 23:23:59 +0100	[thread overview]
Message-ID: <201112212324.00713.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <20111221074347.GA12861@neutronstar.dyndns.org>

Hi Martin,

On Wednesday 21 December 2011 08:43:47 martin@neutronstar.dyndns.org wrote:
> On Wed, Dec 21, 2011 at 02:06:20AM +0100, Laurent Pinchart wrote:
> > On Saturday 17 December 2011 11:10:55 Martin Hostettler wrote:
> > > The MT9M032 is a parallel 1.6MP sensor from Micron controlled through
> > > I2C.
> > > 
> > > The driver creates a V4L2 subdevice. It currently supports cropping,
> > > gain, exposure and v/h flipping controls in monochrome mode with an
> > > external pixel clock.
> > 
> > There are still several small issues with this driver. Things like not
> > using the module_i2c_driver() macro, some indentation, magic values in
> > registers (I'm trying to get more documentation), PLL setup (although
> > that can be fixed later, it's not a requirement for the driver to be
> > mainlined), ...
> > 
> > Would you be fine if I took the patch in my tree, fixed the remaining
> > issues and pushed it to mainline for v3.4 (the time frame is too short
> > for v3.3) ?
> 
> Sure,

Thank you.

> that would be much appreciated. Thanks for reviewing and takeing these
> patches!

You're welcome.

> > Authorship will of course be preserved. The alternative would be to go
> > through review/modification cycles, and I don't want to waste too much
> > of your time
> > 
> > :-)

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2011-12-21 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17 10:10 [PATCH v4] v4l: Add driver for Micron MT9M032 camera sensor Martin Hostettler
2011-12-21  1:06 ` Laurent Pinchart
2011-12-21  7:43   ` martin
2011-12-21 22:23     ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112212324.00713.laurent.pinchart@ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=martin@neutronstar.dyndns.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.