All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Jiri Slaby <jslaby@suse.cz>,
	alan@linux.intel.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/
Date: Wed, 4 Jan 2012 14:03:32 -0800	[thread overview]
Message-ID: <20120104220332.GA22985@suse.de> (raw)
In-Reply-To: <4F04BFA8.9010100@windriver.com>

On Wed, Jan 04, 2012 at 04:07:52PM -0500, Paul Gortmaker wrote:
> On 12-01-04 03:51 PM, Greg KH wrote:
> > On Wed, Jan 04, 2012 at 09:34:36PM +0100, Jiri Slaby wrote:
> >> On 01/04/2012 09:01 PM, Paul Gortmaker wrote:
> >>>  rename drivers/tty/{ => serial}/amiserial.c (100%)
> >>>  rename drivers/tty/{ => serial}/cyclades.c (100%)
> >>>  rename drivers/tty/{ => serial}/isicom.c (100%)
> >>>  rename drivers/tty/{ => serial}/moxa.c (100%)
> >>>  rename drivers/tty/{ => serial}/moxa.h (100%)
> >>>  rename drivers/tty/{ => serial}/mxser.c (100%)
> >>>  rename drivers/tty/{ => serial}/mxser.h (100%)
> >>>  rename drivers/tty/{ => serial}/rocket.c (100%)
> >>>  rename drivers/tty/{ => serial}/rocket.h (100%)
> >>>  rename drivers/tty/{ => serial}/rocket_int.h (100%)
> >>>  rename drivers/tty/{ => serial}/synclink.c (100%)
> >>>  rename drivers/tty/{ => serial}/synclink_gt.c (100%)
> >>>  rename drivers/tty/{ => serial}/synclinkmp.c (100%)
> >>
> >> Hmm, tty/serial/* used to be for those using serial-core. And tty/ for
> >> those who don't. But FWIW I don't mind the change.
> > 
> > Yes, that is what I used when splitting them up, so this patch doesn't
> > make much sense.
> > 
> > Paul, why do you want these all mixed together?
> 
> My thinking was that having a drivers/tty/serial dir and then
> not having all the serial drivers in that dir violated the
> principle of least surprise.  Is there a reason why the dir should
> be the exclusive domain of drivers with a dependency on SERIAL_CORE?

Because that is what the directory is for?  :)

We have other "serial" like drivers all over the kernel, this was for
the SERIAL_CORE drivers only at the moment.

thanks,

greg k-h

  reply	other threads:[~2012-01-04 22:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 20:01 [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/ Paul Gortmaker
2012-01-04 20:34 ` Jiri Slaby
2012-01-04 20:51   ` Greg KH
2012-01-04 21:07     ` Paul Gortmaker
2012-01-04 21:07       ` Paul Gortmaker
2012-01-04 22:03       ` Greg KH [this message]
2012-01-04 23:27         ` Arnd Bergmann
2012-01-05  5:42           ` Sam Ravnborg
2012-01-05 12:45             ` Alan Cox
2012-01-05 23:21               ` Paul Gortmaker
2012-01-05 23:21                 ` Paul Gortmaker
2012-01-06 13:42                 ` Greg KH
2012-02-08 10:30                 ` Jiri Slaby
2012-02-08 10:32                   ` Jiri Slaby
2012-02-08 13:58                     ` Paul Gortmaker
2012-02-08 13:58                       ` Paul Gortmaker
2012-02-08 14:12                     ` Paul Gortmaker
2012-02-08 14:12                       ` Paul Gortmaker
2012-01-04 22:01 ` Alan Cox
2012-01-04 22:43   ` Paul Gortmaker
2012-01-04 22:43     ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120104220332.GA22985@suse.de \
    --to=gregkh@suse.de \
    --cc=alan@linux.intel.com \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.