From: David Teigland <teigland@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination
Date: Thu, 5 Jan 2012 12:13:47 -0500 [thread overview]
Message-ID: <20120105171347.GC22610@redhat.com> (raw)
In-Reply-To: <1325782702.2690.47.camel@menhir>
On Thu, Jan 05, 2012 at 04:58:22PM +0000, Steven Whitehouse wrote:
> > + clear_bit(SDF_NOJOURNALID, &sdp->sd_flags);
> > + smp_mb__after_clear_bit();
> > + wake_up_bit(&sdp->sd_flags, SDF_NOJOURNALID);
> > + ls->ls_first = !!test_bit(DFL_FIRST_MOUNT, &ls->ls_recover_flags);
> > + return 0;
> > +
>
> This bit of code, which was correct last time you posted this patch
> appears to have reverted to its previous incorrect state. ls_first must
Thanks, I'll move it back, I removed ls_first and put it back in the wrong
place. I keep forgetting about it because...
> be set before SDF_NOJOURNALID is cleared, otherwise the uninitialised
> value may be read,
in this case there can be no other reader, so it doesn't matter.
Dave
next prev parent reply other threads:[~2012-01-05 17:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 16:46 [Cluster-devel] [PATCH 5/5] gfs2: dlm based recovery coordination David Teigland
2012-01-05 16:58 ` Steven Whitehouse
2012-01-05 17:13 ` David Teigland [this message]
2012-01-09 16:36 ` Steven Whitehouse
2012-01-09 16:46 ` David Teigland
2012-01-09 17:00 ` David Teigland
2012-01-09 17:04 ` Steven Whitehouse
2012-01-09 17:02 ` Steven Whitehouse
-- strict thread matches above, loose matches on Subject: below --
2011-12-16 22:03 David Teigland
2011-12-19 13:07 ` Steven Whitehouse
2011-12-19 17:47 ` David Teigland
2011-12-20 10:39 ` Steven Whitehouse
2011-12-20 19:16 ` David Teigland
2011-12-20 21:04 ` David Teigland
2011-12-21 10:45 ` Steven Whitehouse
2011-12-21 15:40 ` David Teigland
2011-12-22 21:23 ` David Teigland
2011-12-23 9:19 ` Steven Whitehouse
2011-12-19 15:17 ` Steven Whitehouse
2012-01-05 15:08 ` Bob Peterson
2012-01-05 15:21 ` David Teigland
2012-01-05 15:40 ` Steven Whitehouse
2012-01-05 16:16 ` David Teigland
2012-01-05 16:45 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105171347.GC22610@redhat.com \
--to=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.