All of lore.kernel.org
 help / color / mirror / Atom feed
From: richard.zhao@freescale.com (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: mxc: add dt support for audmux-v2
Date: Fri, 6 Jan 2012 17:14:50 +0800	[thread overview]
Message-ID: <20120106091449.GS2414@b20223-02.ap.freescale.net> (raw)
In-Reply-To: <20120106085617.GK11810@n2100.arm.linux.org.uk>

On Fri, Jan 06, 2012 at 08:56:17AM +0000, Russell King - ARM Linux wrote:
> On Fri, Jan 06, 2012 at 11:25:42AM +0800, Richard Zhao wrote:
> > +#ifdef CONFIG_OF
> > +
> > +static int audmux_v2_probe(struct platform_device *pdev)
> > +{
> > +	struct resource *res;
> > +	int ret = 0;
> > +
> > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	if (!res)
> > +		return -ENODEV;
> > +	if (!request_mem_region(res->start, resource_size(res), "audmux_v2")) {
> > +		dev_err(&pdev->dev, "request_mem_region failed\n");
> > +		return -EBUSY;
> > +	}
> > +
> > +	audmux_base = ioremap(res->start, resource_size(res));
> > +	if (!audmux_base) {
> > +		dev_err(&pdev->dev, "ioremap failed\n");
> > +		ret = -ENODEV;
> > +		goto failed_ioremap;
> > +	}
> > +
> > +	audmux_clk = clk_get(NULL, "audmux");
> 
> NAK.  You have a struct device.  Use it.
Right, Thanks.

Richard
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

  reply	other threads:[~2012-01-06  9:14 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06  3:25 [PATCH 0/6] imx patches when I enable imx6q sabrelite audio Richard Zhao
2012-01-06  3:25 ` [PATCH 1/6] ARM: mxc: make imx_dma_is_general_purpose more generic for sdma Richard Zhao
2012-01-06  9:07   ` Sascha Hauer
2012-01-06  3:25 ` [PATCH 2/6] ARM: imx6q: add cko1 clock Richard Zhao
2012-01-06  3:25 ` [PATCH 3/6] arm/dts: imx6q-sabrelite: add 2P5V and 3P3V regulators Richard Zhao
2012-01-08  9:06   ` Shawn Guo
2012-01-08  9:14     ` Richard Zhao
2012-01-08  9:47       ` Shawn Guo
2012-01-06  3:25 ` [PATCH 4/6] arm/dts: imx6q-sabrelite: add sgtl5000 audio codec Richard Zhao
2012-01-08 14:52   ` Shawn Guo
2012-01-08 20:55     ` Mark Brown
2012-01-09  0:56       ` Shawn Guo
2012-01-09  3:38         ` Rob Herring
2012-01-09  5:05           ` Eric Miao
2012-01-09  5:58             ` Richard Zhao
2012-01-09  6:25             ` Mark Brown
2012-01-09  6:52               ` Shawn Guo
2012-01-09  6:43                 ` Mark Brown
2012-01-09  7:17                   ` Shawn Guo
2012-01-09  7:12                     ` Mark Brown
2012-01-11  0:57                       ` Richard Zhao
2012-01-11  0:59                         ` Mark Brown
2012-01-09  6:47           ` Shawn Guo
2012-01-11  1:33   ` Fabio Estevam
2012-01-11  1:40     ` Richard Zhao
2012-01-06  3:25 ` [PATCH 5/6] ARM: mxc: add dt support for audmux-v2 Richard Zhao
2012-01-06  8:56   ` Russell King - ARM Linux
2012-01-06  9:14     ` Richard Zhao [this message]
2012-01-06  9:13   ` Sascha Hauer
2012-01-06  9:21     ` Richard Zhao
2012-01-06  9:38       ` Sascha Hauer
2012-01-11  5:26       ` Shawn Guo
2012-01-11 13:02         ` Richard Zhao
2012-01-11 17:38           ` Mark Brown
2012-01-12  8:54             ` Richard Zhao
2012-01-06  3:25 ` [PATCH 6/6] ARM: imx6q-sabrelite: add audmux support Richard Zhao
2012-01-08 15:02   ` Shawn Guo
2012-01-08 14:58     ` Richard Zhao
2012-01-09  1:19       ` Shawn Guo
2012-01-09  5:27         ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120106091449.GS2414@b20223-02.ap.freescale.net \
    --to=richard.zhao@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.