From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759300Ab2AFWG3 (ORCPT ); Fri, 6 Jan 2012 17:06:29 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58449 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758810Ab2AFWG1 (ORCPT ); Fri, 6 Jan 2012 17:06:27 -0500 Date: Fri, 6 Jan 2012 14:06:25 -0800 From: Andrew Morton To: Mike Galbraith Cc: David Rientjes , Paul Menage , LKML , Tejun Heo , Li Zefan , Peter Zijlstra Subject: Re: [resubmit] Re: [patch-final] Re: patch] cpusets, cgroups: disallow attaching kthreadd Message-Id: <20120106140625.f5447039.akpm@linux-foundation.org> In-Reply-To: <1323232617.5057.50.camel@marge.simson.net> References: <1316758874.7393.2.camel@marge.simson.net> <1316770936.6641.11.camel@marge.simson.net> <1316775204.7562.9.camel@marge.simson.net> <1316788392.6544.33.camel@marge.simson.net> <1318224892.6161.45.camel@marge.simson.net> <1318233815.6527.5.camel@marge.simson.net> <1318925436.9641.23.camel@marge.simson.net> <1319001860.6222.34.camel@marge.simson.net> <20111206144721.7b1d473d.akpm@linux-foundation.org> <1323227914.5057.10.camel@marge.simson.net> <1323232617.5057.50.camel@marge.simson.net> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 07 Dec 2011 05:36:57 +0100 Mike Galbraith wrote: > cpusets, cgroups: disallow attaching kthreadd > > Allowing kthreadd to be moved to a non-root group makes no sense, it being > a global resource, and needlessly leads unsuspecting users toward trouble. > > 1. An RT workqueue worker thread spawned in a task group with no rt_runtime > allocated is not schedulable. Simple user error, but harmful to the box. > > 2. A worker thread which acquires PF_THREAD_BOUND can never leave a cpuset, > rendering the cpuset immortal. > > Save the user some unexpected trouble, just say no. Someone's been screwing around in linux-next during the merge window. afacit some patch which was previously there has magically disappeared. That killed your patch - the original version of the kernel/sched/core.c chagne applies to the new linux-next but the kernel/cpuset.c part is all wrecked. There's been a lot of screwing around this time. There were a large number of rejects merging current linux-next onto current mainline this morning due to conflicting changes in tools/perf/.