From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sat, 14 Jan 2012 20:42:05 -0500 Subject: [U-Boot] [PATCH 12/17] lcd: Add support for flushing LCD fb from dcache after update In-Reply-To: <1326588449-1794-13-git-send-email-sjg@chromium.org> References: <1326588449-1794-1-git-send-email-sjg@chromium.org> <1326588449-1794-13-git-send-email-sjg@chromium.org> Message-ID: <201201142042.06025.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 14 January 2012 19:47:24 Simon Glass wrote: > --- a/common/cmd_echo.c > +++ b/common/cmd_echo.c > @@ -44,8 +44,9 @@ int do_echo(cmd_tbl_t *cmdtp, int flag, int argc, char * > const argv[]) } > } > > + /* Use puts() so that the LCD sees it as a new line */ > if (putnl) > - putc('\n'); > + puts("\n"); > > return 0; > } this sounds like a hack for a broken LCD core and so the fix should be somewhere in there > --- a/common/lcd.c > +++ b/common/lcd.c > > +static char lcd_flush_dcache; seems like it'd be better as a CONFIG knob > + /* > + * flush_dcache_range() is declared in common.h but it seems that some > + * architectures do not actually implement it. Is there a way to find > + * out whether it exists? For now, ARM is safe. > + */ if those arches don't implement this func, then the failure is on their head. people should feel free to use the cache api we expose in common.h. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: